Skip to content

Add missing paywalls#380

Merged
mariobalca merged 3 commits intomainfrom
enhancement/add-missing-paywalls
Dec 23, 2022
Merged

Add missing paywalls#380
mariobalca merged 3 commits intomainfrom
enhancement/add-missing-paywalls

Conversation

@mariobalca
Copy link
Copy Markdown
Contributor

@mariobalca mariobalca commented Dec 23, 2022

Changes proposed ✍️

  • Add missing paywalls to Eagle Eye and Community Help Center (custom domain)

Screenshots (front-end changes only)

Screenshot 2022-12-23 at 11 13 45

Screenshot 2022-12-23 at 11 13 48

Screenshot 2022-12-23 at 11 14 04

Checklist ✅

  • Label appropriately with Feature, Enhancement, or Bug.
  • Tests are passing.
  • New backend functionality has been unit-tested.
  • Environment variables have been updated:
    • Local frontend configuration: frontend/.env.dist.local, frontend/.env.dist.composed.
    • Local backend: backend/.env.dist.local, backend/.env.dist.composed.
    • Configuration docs have been updated.
    • Team members only: update environment variables in override, staging and production env. files and trigger update config script.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.
  • All changes have been tested in a staging site.
  • All changes are working locally running crowd.dev's Docker local environment.

@mariobalca mariobalca added the Improvement Created by Linear-GitHub Sync label Dec 23, 2022
@mariobalca mariobalca self-assigned this Dec 23, 2022
@mariobalca mariobalca changed the title Enhancement/add missing paywalls Add missing paywalls Dec 23, 2022
imageClass: 'absolute bottom-0 right-0',
imageWrapperClass: 'h-30',
content:
'In order to setup a custom domain to your help center public page its required to upgrade your plan',
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sentence feels a bit weird. Probably missing a comma before "its", and shouldn't its be it's?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing this, I blindly copied the copy from Figma 😅

})

const page = computed(() => pageContent[props.module])
const computedFeaturePlan = computed(() => {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On this file (line 18) there is also a pre title with "Growth feature". Could you also update that one? 🙏

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved everything to Premium feature, easier to not get repetitive on the terminology

Copy link
Copy Markdown
Contributor

@joanagmaia joanagmaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💪

@mariobalca mariobalca merged commit 9069e5a into main Dec 23, 2022
@mariobalca mariobalca deleted the enhancement/add-missing-paywalls branch December 23, 2022 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Improvement Created by Linear-GitHub Sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants