Skip to content

fix: optimize member identity queries to use VALUES clause joins #3820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skwowet merged 4 commits into from
Feb 3, 2026
Merged

fix: optimize member identity queries to use VALUES clause joins #3820

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
81f83a4
refactor: optimize member identity queries by using VALUES clause for…
skwowet Feb 3, 2026
46bb1fc
refactor: enhance member identity queries by implementing VALUES clau…
skwowet Feb 3, 2026
2460c84
Merge branch 'main' into hotfix-data-sink-worker
skwowet Feb 3, 2026
df9fc6e
fix: ensure case-insensitive matching for member identity values in q…
skwowet Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
102 changes: 58 additions & 44 deletions services/libs/data-access-layer/src/member_identities/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,49 +227,65 @@ export async function findAlreadyExistingVerifiedIdentities(
return []
}

const conditions: string[] = []
const values: string[] = []
const valuesClause = p.identities
.map((_, i) => `($(platform_${i}), $(type_${i}), $(value_${i}))`)
.join(', ')

p.identities.forEach((identity, index) => {
conditions.push(`(mi.platform = $${index * 2 + 1} AND mi.value = $${index * 2 + 2})`)
values.push(identity.platform, identity.value)
const data: Record<string, string> = {}
p.identities.forEach((identity, i) => {
data[`platform_${i}`] = identity.platform
data[`type_${i}`] = identity.type
data[`value_${i}`] = identity.value.toLowerCase()
})

const whereClause = `(${conditions.join(' OR ')})`

return qx.select(
`
with input_identities (platform, type, value_lower) as (
values ${valuesClause}
)
select mi.*
from "memberIdentities" mi
where ${whereClause}
and mi."deletedAt" is null
inner join input_identities i
on mi.platform = i.platform
and mi.type = i.type
and lower(mi.value) = i.value_lower
where mi."deletedAt" is null
`,
values,
data,
)
}

export async function findMembersByVerifiedEmails(
qx: QueryExecutor,
emails: string[],
): Promise<Map<string, IDbMember>> {
const data = {
if (emails.length === 0) {
return new Map()
}

const valuesClause = emails.map((_, i) => `($(email_${i}))`).join(', ')

const data: Record<string, string> = {
type: MemberIdentityType.EMAIL,
emails: emails.map((e) => e.toLowerCase()),
}

emails.forEach((email, i) => {
data[`email_${i}`] = email.toLowerCase()
})

const results = await qx.select(
`
with matching_identities as (
select mi."memberId", mi.value
from "memberIdentities" mi
where mi.verified = true
and mi.type = $(type)
and lower(mi.value) in ($(emails:csv))
and mi."deletedAt" is null
limit ${emails.length}
with input_emails (value_lower) as (
values ${valuesClause}
)
select mi.value as "identityValue", ${MEMBER_SELECT_COLUMNS.map((c) => `m."${c}"`).join(', ')}
from "members" m inner join matching_identities mi on m.id = mi."memberId"
from "memberIdentities" mi
inner join input_emails i on lower(mi.value) = i.value_lower
inner join "members" m on m.id = mi."memberId"
where mi.verified = true
and mi.type = $(type)
and mi."deletedAt" is null
limit ${emails.length}
`,
data,
)
Expand All @@ -287,38 +303,36 @@ export async function findMembersByVerifiedUsernames(
qx: QueryExecutor,
params: { segmentId: string; platform: string; username: string }[],
): Promise<Map<{ platform: string; value: string }, IDbMember>> {
const orConditions: string[] = []
let index = 0
if (params.length === 0) {
return new Map()
}

const valuesClause = params.map((_, i) => `($(platform_${i}), $(username_${i}))`).join(', ')

const data: Record<string, string> = {
type: MemberIdentityType.USERNAME,
}

for (const param of params) {
const platformParam = `platform_${index++}`
const usernameParam = `username_${index++}`

orConditions.push(
`(mi.platform = $(${platformParam}) and lower(mi.value) = $(${usernameParam}))`,
)

data[platformParam] = param.platform
data[usernameParam] = param.username.toLowerCase()
}
params.forEach((param, i) => {
data[`platform_${i}`] = param.platform
data[`username_${i}`] = param.username.toLowerCase()
})

const results = await qx.select(
`
with matching_identities as (
select mi."memberId", mi.platform, mi.value
from "memberIdentities" mi
where mi.verified = true
and mi.type = $(type)
and mi."deletedAt" is null
and (${orConditions.join(' or ')})
limit ${params.length}
with input_identities (platform, value_lower) as (
values ${valuesClause}
)
select mi.platform as "identityPlatform", mi.value as "identityValue", ${MEMBER_SELECT_COLUMNS.map((c) => `m."${c}"`).join(', ')}
from "members" m inner join matching_identities mi on m.id = mi."memberId"
from "memberIdentities" mi
inner join input_identities i
on mi.platform = i.platform
and lower(mi.value) = i.value_lower
inner join "members" m on m.id = mi."memberId"
where mi.verified = true
and mi.type = $(type)
and mi."deletedAt" is null
limit ${params.length}
`,
data,
)
Expand Down Expand Up @@ -364,7 +378,7 @@ export async function findMembersByIdentities(
from "memberIdentities" mi
inner join input_identities i
on mi.platform = i.platform
and mi.value = i.value
and lower(mi.value) = lower(i.value)
and mi.type = i.type
and mi."deletedAt" is null
where ${conditions.join(' and ')}
Expand Down