Skip to content

feat: include GitHub handles#3857

Merged
emlimlf merged 10 commits intomainfrom
feat/include-github-handles
Feb 19, 2026
Merged

feat: include GitHub handles#3857
emlimlf merged 10 commits intomainfrom
feat/include-github-handles

Conversation

@emlimlf
Copy link
Copy Markdown
Collaborator

@emlimlf emlimlf commented Feb 18, 2026

In this PR

Added all the verified github handles to the members sorted and all the leaderboard pipes

Ticket

IN-974


Note

Medium Risk
Touches multiple Tinybird datasources/pipes and changes output schema types (string � array), which can break downstream consumers and requires backfill/migration validation.

Overview
Updates Tinybird schemas and pipes to return all verified GitHub usernames per member as githubHandleArray (Array(String)) instead of a single githubHandle string.

members_sorted_copy_pipe now aggregates verified GitHub usernames via groupArray from memberIdentities and denormalizes them into members_sorted; all leaderboard-related copy/query pipes and leaderboards_copy_ds are updated to select/emit githubHandleArray (using [] defaults for non-contributor leaderboards).

Written by Cursor Bugbot for commit 2c0362c. This will update automatically on new commits. Configure here.

Signed-off-by: Efren Lim <elim@linuxfoundation.org>
Signed-off-by: Efren Lim <elim@linuxfoundation.org>
@emlimlf emlimlf requested a review from gaspergrom February 18, 2026 11:26
@github-actions
Copy link
Copy Markdown
Contributor

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

  • feat: add user authentication (CM-123)
  • feat: add user authentication (IN-123)

Projects:

  • CM: Community Data Platform
  • IN: Insights

Please add a Jira issue key to your PR title.

3 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

  • feat: add user authentication (CM-123)
  • feat: add user authentication (IN-123)

Projects:

  • CM: Community Data Platform
  • IN: Insights

Please add a Jira issue key to your PR title.

@github-actions
Copy link
Copy Markdown
Contributor

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

  • feat: add user authentication (CM-123)
  • feat: add user authentication (IN-123)

Projects:

  • CM: Community Data Platform
  • IN: Insights

Please add a Jira issue key to your PR title.

@github-actions
Copy link
Copy Markdown
Contributor

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

  • feat: add user authentication (CM-123)
  • feat: add user authentication (IN-123)

Projects:

  • CM: Community Data Platform
  • IN: Insights

Please add a Jira issue key to your PR title.

Comment thread services/libs/tinybird/pipes/members_sorted_copy_pipe.pipe Outdated
Copy link
Copy Markdown
Contributor

@gaspergrom gaspergrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep just github one githubHandle property

@github-actions
Copy link
Copy Markdown
Contributor

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

  • feat: add user authentication (CM-123)
  • feat: add user authentication (IN-123)

Projects:

  • CM: Community Data Platform
  • IN: Insights

Please add a Jira issue key to your PR title.

@emlimlf
Copy link
Copy Markdown
Collaborator Author

emlimlf commented Feb 19, 2026

@gaspergrom I made it this way so that the frontend doesn't produce an error because of the change. Once this PR: linuxfoundation/insights#1685 is merged and deployed to prod, I can remove the other github handle property and just keep the array one.

Signed-off-by: Efren Lim <elim@linuxfoundation.org>
@emlimlf emlimlf requested a review from gaspergrom February 19, 2026 05:25
@emlimlf
Copy link
Copy Markdown
Collaborator Author

emlimlf commented Feb 19, 2026

Anyway, I've removed the old github handle property. But this must not be deployed and merge until the frontend PR has been merged and deployed to prod.

@github-actions
Copy link
Copy Markdown
Contributor

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

  • feat: add user authentication (CM-123)
  • feat: add user authentication (IN-123)

Projects:

  • CM: Community Data Platform
  • IN: Insights

Please add a Jira issue key to your PR title.

Comment thread services/libs/tinybird/pipes/leaderboards_members.pipe Outdated
@github-actions
Copy link
Copy Markdown
Contributor

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

  • feat: add user authentication (CM-123)
  • feat: add user authentication (IN-123)

Projects:

  • CM: Community Data Platform
  • IN: Insights

Please add a Jira issue key to your PR title.

Signed-off-by: Efren Lim <elim@linuxfoundation.org>
@github-actions
Copy link
Copy Markdown
Contributor

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

  • feat: add user authentication (CM-123)
  • feat: add user authentication (IN-123)

Projects:

  • CM: Community Data Platform
  • IN: Insights

Please add a Jira issue key to your PR title.

Signed-off-by: Efren Lim <elim@linuxfoundation.org>
@github-actions
Copy link
Copy Markdown
Contributor

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

  • feat: add user authentication (CM-123)
  • feat: add user authentication (IN-123)

Projects:

  • CM: Community Data Platform
  • IN: Insights

Please add a Jira issue key to your PR title.

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

NODE github_usernames_array
SQL >
SELECT memberId, argMax(value, createdAt) AS githubHandle
SELECT memberId, groupArray(value) AS githubHandleArray
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing deduplication produces duplicate GitHub handles in array

Low Severity

groupArray(value) collects all values without deduplication. The memberIdentities table's ReplacingMergeTree deduplicates by (integrationId, memberId, id), so after FINAL, the same GitHub username can still appear in multiple rows if it was discovered by different integrations (different integrationId or id). This produces duplicate entries like ['octocat', 'octocat'] in githubHandleArray. The previous argMax approach inherently returned a single value, so this is a regression. groupUniqArray would be more appropriate here.

Fix in Cursor Fix in Web

@github-actions
Copy link
Copy Markdown
Contributor

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

  • feat: add user authentication (CM-123)
  • feat: add user authentication (IN-123)

Projects:

  • CM: Community Data Platform
  • IN: Insights

Please add a Jira issue key to your PR title.

Signed-off-by: Efren Lim <elim@linuxfoundation.org>
@github-actions
Copy link
Copy Markdown
Contributor

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

  • feat: add user authentication (CM-123)
  • feat: add user authentication (IN-123)

Projects:

  • CM: Community Data Platform
  • IN: Insights

Please add a Jira issue key to your PR title.

@emlimlf emlimlf merged commit a956c67 into main Feb 19, 2026
16 checks passed
@emlimlf emlimlf deleted the feat/include-github-handles branch February 19, 2026 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants