Conversation
Signed-off-by: Efren Lim <elim@linuxfoundation.org>
Signed-off-by: Efren Lim <elim@linuxfoundation.org>
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
3 similar comments
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
gaspergrom
left a comment
There was a problem hiding this comment.
keep just github one githubHandle property
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
|
@gaspergrom I made it this way so that the frontend doesn't produce an error because of the change. Once this PR: linuxfoundation/insights#1685 is merged and deployed to prod, I can remove the other github handle property and just keep the array one. |
Signed-off-by: Efren Lim <elim@linuxfoundation.org>
|
Anyway, I've removed the old github handle property. But this must not be deployed and merge until the frontend PR has been merged and deployed to prod. |
…crowd.dev into feat/include-github-handles
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
Signed-off-by: Efren Lim <elim@linuxfoundation.org>
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
Signed-off-by: Efren Lim <elim@linuxfoundation.org>
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
| NODE github_usernames_array | ||
| SQL > | ||
| SELECT memberId, argMax(value, createdAt) AS githubHandle | ||
| SELECT memberId, groupArray(value) AS githubHandleArray |
There was a problem hiding this comment.
Missing deduplication produces duplicate GitHub handles in array
Low Severity
groupArray(value) collects all values without deduplication. The memberIdentities table's ReplacingMergeTree deduplicates by (integrationId, memberId, id), so after FINAL, the same GitHub username can still appear in multiple rows if it was discovered by different integrations (different integrationId or id). This produces duplicate entries like ['octocat', 'octocat'] in githubHandleArray. The previous argMax approach inherently returned a single value, so this is a regression. groupUniqArray would be more appropriate here.
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
Signed-off-by: Efren Lim <elim@linuxfoundation.org>
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |


In this PR
Added all the verified github handles to the members sorted and all the leaderboard pipes
Ticket
IN-974
Note
Medium Risk
Touches multiple Tinybird datasources/pipes and changes output schema types (string � array), which can break downstream consumers and requires backfill/migration validation.
Overview
Updates Tinybird schemas and pipes to return all verified GitHub usernames per member as
githubHandleArray(Array(String)) instead of a singlegithubHandlestring.members_sorted_copy_pipenow aggregates verified GitHub usernames viagroupArrayfrommemberIdentitiesand denormalizes them intomembers_sorted; all leaderboard-related copy/query pipes andleaderboards_copy_dsare updated to select/emitgithubHandleArray(using[]defaults for non-contributor leaderboards).Written by Cursor Bugbot for commit 2c0362c. This will update automatically on new commits. Configure here.