Skip to content

Cubejs preaggregations dimension updates#386

Merged
epipav merged 4 commits into
mainfrom
improvement/cubejs-preaggregations-dimension-updates
Jan 2, 2023
Merged

Cubejs preaggregations dimension updates#386
epipav merged 4 commits into
mainfrom
improvement/cubejs-preaggregations-dimension-updates

Conversation

@epipav
Copy link
Copy Markdown
Collaborator

@epipav epipav commented Jan 2, 2023

Changes proposed ✍️

  • After introducing isTeamMember and isBot as universal filters to all cubes, preaggregations were not matching their definitions anymore, resulting in a long query response time. This pr aims to add these dimensions also to preaggregations.

Checklist ✅

  • Label appropriately with Feature, Enhancement, or Bug.
  • Tests are passing.
  • New backend functionality has been unit-tested.
  • Environment variables have been updated:
    • Local frontend configuration: frontend/.env.dist.local, frontend/.env.dist.composed.
    • Local backend: backend/.env.dist.local, backend/.env.dist.composed.
    • Configuration docs have been updated.
    • Team members only: update environment variables in override, staging and production env. files and trigger update config script.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.
  • All changes have been tested in a staging site.
  • All changes are working locally running crowd.dev's Docker local environment.

@epipav epipav self-assigned this Jan 2, 2023
@epipav epipav added the Improvement Created by Linear-GitHub Sync label Jan 2, 2023
@epipav epipav requested a review from mariobalca January 2, 2023 12:46
@epipav epipav marked this pull request as ready for review January 2, 2023 13:07
Copy link
Copy Markdown
Contributor

@mariobalca mariobalca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙌

@epipav epipav merged commit 484fd58 into main Jan 2, 2023
@epipav epipav deleted the improvement/cubejs-preaggregations-dimension-updates branch January 2, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Improvement Created by Linear-GitHub Sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants