chore: move overview module out of admin folder#3860
Conversation
Signed-off-by: Efren Lim <elim@linuxfoundation.org>
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
3 similar comments
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| import LfIcon from '@/ui-kit/icon/Icon.vue'; | ||
| import type { OverviewTrends } from '@/modules/admin/modules/overview/types/overview.types'; | ||
| import { formatNumber } from '@/utils/number'; | ||
| import type { OverviewTrends } from '@/modules/admin/modules/overview/types/overview.types'; |
There was a problem hiding this comment.
Stale import path for OverviewTrends in trend-display
High Severity
The OverviewTrends type import in trend-display.vue still points to the old path @/modules/admin/modules/overview/types/overview.types, but that file no longer exists — it was moved to @/modules/overview/types/overview.types.ts. Every other sibling file correctly uses the relative import ../../types/overview.types, but this one was missed during the move. This will break the build.
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
2 participants
In this PR
Moved the overview module out of the admin module folder
Ticket
CM-982
Note
Medium Risk
Mostly mechanical import-path changes, but routing/import resolution can break at runtime/build time; at least one file still references the old overview types path.
Overview
Moves the Overview page out of the admin module by repointing the admin
/overviewroute to@/modules/overview/pages/overview.vueand updating Overview components to use the new module-local relative imports.This is primarily a path/refactor change, but there’s a likely leftover dependency:
trend-display.vuestill importsOverviewTrendsfrom the old@/modules/admin/modules/overview/...path, which may break builds if the old module is removed.Written by Cursor Bugbot for commit b78c032. This will update automatically on new commits. Configure here.