Skip to content

fix: sitemap pipes (IN-1059)#3949

Merged
joanagmaia merged 2 commits intomainfrom
fix/sitemap-pipes
Mar 24, 2026
Merged

fix: sitemap pipes (IN-1059)#3949
joanagmaia merged 2 commits intomainfrom
fix/sitemap-pipes

Conversation

@joanagmaia
Copy link
Copy Markdown
Contributor

@joanagmaia joanagmaia commented Mar 24, 2026

This pull request updates the SQL queries in several Tinybird sitemap pipes to ensure that only non-deleted records are included in the results. The main change is the addition of a filter that excludes any records where the deletedAt field is set.

Filtering for non-deleted records in sitemap pipes:

  • Updated sitemap_categories.pipe to select only categories where deletedAt is null.
  • Updated sitemap_category_groups.pipe to select only category groups where deletedAt is null.
  • Updated sitemap_projects.pipe to select only projects where deletedAt is null.

Note

Low Risk
Low risk SQL-only change that tightens sitemap outputs by filtering out rows with deletedAt set. Potential risk is unintentionally omitting entries if deletedAt is populated unexpectedly or nullability differs across tables.

Overview
Updates Tinybird sitemap pipes to exclude soft-deleted rows by adding WHERE isNull(deletedAt) to the slug queries for categories, categoryGroups, and insightsProjects, so sitemaps no longer include deleted entries.

Written by Cursor Bugbot for commit 5ba9297. This will update automatically on new commits. Configure here.

Signed-off-by: Joana Maia <jmaia@contractor.linuxfoundation.org>
@github-actions
Copy link
Copy Markdown
Contributor

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

  • feat: add user authentication (CM-123)
  • feat: add user authentication (IN-123)

Projects:

  • CM: Community Data Platform
  • IN: Insights

Please add a Jira issue key to your PR title.

1 similar comment
@github-actions
Copy link
Copy Markdown
Contributor

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

  • feat: add user authentication (CM-123)
  • feat: add user authentication (IN-123)

Projects:

  • CM: Community Data Platform
  • IN: Insights

Please add a Jira issue key to your PR title.

@github-actions
Copy link
Copy Markdown
Contributor

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

  • feat: add user authentication (CM-123)
  • feat: add user authentication (IN-123)

Projects:

  • CM: Community Data Platform
  • IN: Insights

Please add a Jira issue key to your PR title.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Tinybird sitemap pipes so that sitemap outputs only include non-deleted records by filtering out rows where deletedAt is set.

Changes:

  • Add WHERE isNull (deletedAt) to insightsProjects sitemap slug query
  • Add WHERE isNull (deletedAt) to categoryGroups sitemap slug query
  • Add WHERE isNull (deletedAt) to categories sitemap slug query

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
services/libs/tinybird/pipes/sitemap_projects.pipe Excludes soft-deleted projects from sitemap slugs.
services/libs/tinybird/pipes/sitemap_category_groups.pipe Excludes soft-deleted category groups from sitemap slugs.
services/libs/tinybird/pipes/sitemap_categories.pipe Excludes soft-deleted categories from sitemap slugs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@joanagmaia joanagmaia changed the title fix: sitemap pipes fix: sitemap pipes (IN-1059) Mar 24, 2026
@joanagmaia joanagmaia merged commit 6f9260a into main Mar 24, 2026
15 checks passed
@joanagmaia joanagmaia deleted the fix/sitemap-pipes branch March 24, 2026 12:19
skwowet pushed a commit that referenced this pull request Mar 25, 2026
Signed-off-by: Joana Maia <jmaia@contractor.linuxfoundation.org>
Signed-off-by: Yeganathan S <63534555+skwowet@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants