fix: sitemap pipes (IN-1059)#3949
Conversation
Signed-off-by: Joana Maia <jmaia@contractor.linuxfoundation.org>
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
1 similar comment
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
There was a problem hiding this comment.
Pull request overview
This PR updates Tinybird sitemap pipes so that sitemap outputs only include non-deleted records by filtering out rows where deletedAt is set.
Changes:
- Add
WHERE isNull (deletedAt)toinsightsProjectssitemap slug query - Add
WHERE isNull (deletedAt)tocategoryGroupssitemap slug query - Add
WHERE isNull (deletedAt)tocategoriessitemap slug query
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| services/libs/tinybird/pipes/sitemap_projects.pipe | Excludes soft-deleted projects from sitemap slugs. |
| services/libs/tinybird/pipes/sitemap_category_groups.pipe | Excludes soft-deleted category groups from sitemap slugs. |
| services/libs/tinybird/pipes/sitemap_categories.pipe | Excludes soft-deleted categories from sitemap slugs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Joana Maia <jmaia@contractor.linuxfoundation.org> Signed-off-by: Yeganathan S <63534555+skwowet@users.noreply.github.com>
This pull request updates the SQL queries in several Tinybird sitemap pipes to ensure that only non-deleted records are included in the results. The main change is the addition of a filter that excludes any records where the
deletedAtfield is set.Filtering for non-deleted records in sitemap pipes:
sitemap_categories.pipeto select only categories wheredeletedAtis null.sitemap_category_groups.pipeto select only category groups wheredeletedAtis null.sitemap_projects.pipeto select only projects wheredeletedAtis null.Note
Low Risk
Low risk SQL-only change that tightens sitemap outputs by filtering out rows with
deletedAtset. Potential risk is unintentionally omitting entries ifdeletedAtis populated unexpectedly or nullability differs across tables.Overview
Updates Tinybird sitemap pipes to exclude soft-deleted rows by adding
WHERE isNull(deletedAt)to the slug queries forcategories,categoryGroups, andinsightsProjects, so sitemaps no longer include deleted entries.Written by Cursor Bugbot for commit 5ba9297. This will update automatically on new commits. Configure here.