Skip to content

Added the special type for member attributes#431

Merged
joanreyero merged 3 commits into
mainfrom
improvement/special-attribute-type
Jan 18, 2023
Merged

Added the special type for member attributes#431
joanreyero merged 3 commits into
mainfrom
improvement/special-attribute-type

Conversation

@joanreyero
Copy link
Copy Markdown
Contributor

@joanreyero joanreyero commented Jan 18, 2023

Changes proposed ✍️

  • Added a special attribute type that can hold any value. It will not be filterable.

Checklist ✅

  • Label appropriately with Feature, Enhancement, or Bug.
  • Tests are passing.
  • New backend functionality has been unit-tested.
  • Environment variables have been updated:
    • Local frontend configuration: frontend/.env.dist.local, frontend/.env.dist.composed.
    • Local backend: backend/.env.dist.local, backend/.env.dist.composed.
    • Configuration docs have been updated.
    • Team members only: update environment variables in override, staging and production env. files and trigger update config script.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.
  • All changes have been tested in a staging site.
  • All changes are working locally running crowd.dev's Docker local environment.

@joanreyero joanreyero added the Feature Created by Linear-GitHub Sync label Jan 18, 2023
@joanreyero joanreyero requested a review from epipav January 18, 2023 11:05
@joanreyero joanreyero changed the title Added the special type Added the special type for member attributes Jan 18, 2023
@joanreyero joanreyero self-assigned this Jan 18, 2023
Copy link
Copy Markdown
Collaborator

@epipav epipav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Since the special attributes won't be filterable, can we exclude these from MemberService.query and ActivityService.query(This part is still not merged yet) functions when we feed the attributes into findAndCountAll function?

@joanreyero joanreyero merged commit 360bd76 into main Jan 18, 2023
@joanreyero joanreyero deleted the improvement/special-attribute-type branch January 18, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature Created by Linear-GitHub Sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants