Add Formbricks Product-Market-Fit widget#467
Merged
Merged
Conversation
…icts between pmf and feedback widget
joanreyero
requested changes
Feb 10, 2023
Contributor
There was a problem hiding this comment.
Thanks a lot for the contribution! 😊
A couple of files need changes for the deployment to pick up the new environment variable.
frontend/scripts/docker-entrypoint.sh: Add"VUE_APP_FORMBRICKS_PMF_FORM_ID"to line 30frontend/src/config.js: AddpmfFormId: 'CROWD_VUE_APP_FORMBRICKS_PMF_FORM_ID'to line 91
Otherwise, it looks great! 🔥
Contributor
Author
|
@joanreyero thanks for reviewing 🤗 |
joanreyero
pushed a commit
that referenced
this pull request
Apr 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed ✍️
Replace the Typeform Product-Market-Fit-Survey widget with the Formbricks Pmf widget as discussed with Jonathan.
The condition for displaying the banner has been set as follows:
You will need to set the following environment variables
The Formbricks cloud has moved from xm.formbricks.com to app.formbricks.com. Please create a new account to use the PMF feature.
Todo:
formbricksPmf.init()is called whenshowPmfSurveyis changed. To wait for the rerender to be completed, a setTimeout is used. This can be solved better (but is beyond my vue.js skills 😉)