Skip to content

Bulk enrichment error messages#477

Merged
joanagmaia merged 7 commits into
mainfrom
bug/bulk-enrichment-error-messages
Feb 1, 2023
Merged

Bulk enrichment error messages#477
joanagmaia merged 7 commits into
mainfrom
bug/bulk-enrichment-error-messages

Conversation

@joanagmaia
Copy link
Copy Markdown
Contributor

@joanagmaia joanagmaia commented Jan 31, 2023

Changes proposed ✍️

  • Websocket bulk enrichment:
    • Only send error message from websocket if all enrichment fails
    • Only send success message if there were enriched members
  • Toast Messages frontend:
    • Update error message to be: "Failed to enrich x members.`"
  • Bulk enrichment actions toolbar:
    • Only send elegible members' ids to the bulk request (before it was sending all selected ids)

Checklist ✅

  • Label appropriately with Feature, Enhancement, or Bug.
  • Tests are passing.
  • New backend functionality has been unit-tested.
  • Environment variables have been updated:
    • Local frontend configuration: frontend/.env.dist.local, frontend/.env.dist.composed.
    • Local backend: backend/.env.dist.local, backend/.env.dist.composed.
    • Configuration docs have been updated.
    • Team members only: update environment variables in override, staging and production env. files and trigger update config script.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.
  • All changes have been tested in a staging site.
  • All changes are working locally running crowd.dev's Docker local environment.

@joanagmaia joanagmaia added the Bug Created by Linear-GitHub Sync label Jan 31, 2023
@joanagmaia joanagmaia self-assigned this Jan 31, 2023
Copy link
Copy Markdown
Contributor

@mariobalca mariobalca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice work 👏

@joanagmaia joanagmaia merged commit f66f504 into main Feb 1, 2023
@joanagmaia joanagmaia deleted the bug/bulk-enrichment-error-messages branch February 1, 2023 10:15
joanreyero pushed a commit that referenced this pull request Apr 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Created by Linear-GitHub Sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants