Skip to content

Share button visible on custom reports page#484

Merged
joanagmaia merged 2 commits into
mainfrom
feature/share-visible-C-591
Feb 7, 2023
Merged

Share button visible on custom reports page#484
joanagmaia merged 2 commits into
mainfrom
feature/share-visible-C-591

Conversation

@gaspergrom
Copy link
Copy Markdown
Contributor

Changes proposed ✍️

  • remove button from custom report edit screen

  • adjust share button colors

  • add share button to custom report view page

  • Screenshots (front-end changes only)

image

Checklist ✅

  • Label appropriately with Feature, Enhancement, or Bug.
  • Tests are passing.
  • New backend functionality has been unit-tested.
  • Environment variables have been updated:
    • Local frontend configuration: frontend/.env.dist.local, frontend/.env.dist.composed.
    • Local backend: backend/.env.dist.local, backend/.env.dist.composed.
    • Configuration docs have been updated.
    • Team members only: update environment variables in override, staging and production env. files and trigger update config script.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.
  • All changes have been tested in a staging site.
  • All changes are working locally running crowd.dev's Docker local environment.

@gaspergrom gaspergrom added the Improvement Created by Linear-GitHub Sync label Feb 6, 2023
@gaspergrom gaspergrom requested a review from joanagmaia February 6, 2023 10:37
@gaspergrom gaspergrom self-assigned this Feb 6, 2023
Copy link
Copy Markdown
Contributor

@joanagmaia joanagmaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Not sure if you did but I would just validate the visual update on the button with Nuno. Other than that feel free to merge it 👌

Copy link
Copy Markdown
Contributor

@joanagmaia joanagmaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the updates!

@joanagmaia joanagmaia merged commit a6a5af0 into main Feb 7, 2023
@joanagmaia joanagmaia deleted the feature/share-visible-C-591 branch February 7, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Improvement Created by Linear-GitHub Sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants