Skip to content

Fix filters for custom attributes#492

Merged
joanagmaia merged 2 commits into
mainfrom
bug/members-filters
Feb 8, 2023
Merged

Fix filters for custom attributes#492
joanagmaia merged 2 commits into
mainfrom
bug/members-filters

Conversation

@joanagmaia
Copy link
Copy Markdown
Contributor

Changes proposed ✍️

  • Create a new field to handle multi-select filter with pre-existent options. Sort options alphabetically
  • After bulk enrichment, fetch attributes to get the latest attributes and options
  • For "multi-select" and "special" render the new filter component. For "multi-select" and "special" that do not have available options, do not render as a filter

Screenshots (front-end changes only)

Screenshot 2023-02-08 at 10 03 28

Checklist ✅

  • Label appropriately with Feature, Enhancement, or Bug.
  • Tests are passing.
  • New backend functionality has been unit-tested.
  • Environment variables have been updated:
    • Local frontend configuration: frontend/.env.dist.local, frontend/.env.dist.composed.
    • Local backend: backend/.env.dist.local, backend/.env.dist.composed.
    • Configuration docs have been updated.
    • Team members only: update environment variables in override, staging and production env. files and trigger update config script.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.
  • All changes have been tested in a staging site.
  • All changes are working locally running crowd.dev's Docker local environment.

@joanagmaia joanagmaia added the Bug Created by Linear-GitHub Sync label Feb 8, 2023
@joanagmaia joanagmaia requested a review from joanreyero February 8, 2023 10:30
@joanagmaia joanagmaia self-assigned this Feb 8, 2023
Copy link
Copy Markdown
Contributor

@joanreyero joanreyero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 🚀

@joanagmaia joanagmaia merged commit 784a158 into main Feb 8, 2023
@joanagmaia joanagmaia deleted the bug/members-filters branch February 8, 2023 12:23
joanagmaia added a commit that referenced this pull request Feb 20, 2023
joanreyero pushed a commit that referenced this pull request Apr 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Created by Linear-GitHub Sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants