Skip to content

Fix sample data permissions#497

Merged
joanreyero merged 2 commits into
mainfrom
bugfix/sample-data-permissions
Feb 8, 2023
Merged

Fix sample data permissions#497
joanreyero merged 2 commits into
mainfrom
bugfix/sample-data-permissions

Conversation

@joanreyero
Copy link
Copy Markdown
Contributor

@joanreyero joanreyero commented Feb 8, 2023

Changes proposed ✍️

  • Added permissions to add and delete sample data
  • Handling Delete forbidden on the frontend

Checklist ✅

  • Label appropriately with Feature, Enhancement, or Bug.
  • Tests are passing.
  • New backend functionality has been unit-tested.
  • Environment variables have been updated:
    • Local frontend configuration: frontend/.env.dist.local, frontend/.env.dist.composed.
    • Local backend: backend/.env.dist.local, backend/.env.dist.composed.
    • Configuration docs have been updated.
    • Team members only: update environment variables in override, staging and production env. files and trigger update config script.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.
  • All changes have been tested in a staging site.
  • All changes are working locally running crowd.dev's Docker local environment.

@joanreyero joanreyero added the Bug Created by Linear-GitHub Sync label Feb 8, 2023
@joanreyero joanreyero marked this pull request as ready for review February 8, 2023 16:17
@joanreyero joanreyero requested a review from joanagmaia February 8, 2023 16:17
Copy link
Copy Markdown
Contributor

@joanagmaia joanagmaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@joanreyero joanreyero changed the title Bugfix/sample data permissions Fix sample data permissions Feb 8, 2023
@joanreyero joanreyero merged commit 7334254 into main Feb 8, 2023
@joanreyero joanreyero deleted the bugfix/sample-data-permissions branch February 8, 2023 17:03
joanagmaia pushed a commit that referenced this pull request Feb 20, 2023
joanreyero pushed a commit that referenced this pull request Apr 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Created by Linear-GitHub Sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants