Skip to content

[C-750] Email digest settings#498

Merged
gaspergrom merged 9 commits into
feature/eagle-eye-2from
feature/email-digest-C-750
Feb 14, 2023
Merged

[C-750] Email digest settings#498
gaspergrom merged 9 commits into
feature/eagle-eye-2from
feature/email-digest-C-750

Conversation

@gaspergrom
Copy link
Copy Markdown
Contributor

@gaspergrom gaspergrom commented Feb 9, 2023

Changes proposed ✍️

  • email digest drawer
  • connect drawer to feed

Screenshots (front-end changes only)

image

Checklist ✅

  • Label appropriately with Feature, Enhancement, or Bug.
  • Tests are passing.
  • New backend functionality has been unit-tested.
  • Environment variables have been updated:
    • Local frontend configuration: frontend/.env.dist.local, frontend/.env.dist.composed.
    • Local backend: backend/.env.dist.local, backend/.env.dist.composed.
    • Configuration docs have been updated.
    • Team members only: update environment variables in override, staging and production env. files and trigger update config script.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.
  • All changes have been tested in a staging site.
  • All changes are working locally running crowd.dev's Docker local environment.

@gaspergrom gaspergrom self-assigned this Feb 13, 2023
@gaspergrom gaspergrom added the Feature Created by Linear-GitHub Sync label Feb 13, 2023
@gaspergrom gaspergrom marked this pull request as ready for review February 13, 2023 15:28
Copy link
Copy Markdown
Contributor

@joanagmaia joanagmaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think in terms of the UI there are 2 things missing:

  1. Required icon "*" missing in email
  2. Deactivated state of drawer should be opaque, disabling the fields

Could you take a look at it? 🙏

Comment thread frontend/src/premium/eagle-eye/components/list/eagle-eye-email-digest-drawer.vue Outdated
Comment thread frontend/src/premium/eagle-eye/components/list/eagle-eye-email-digest-drawer.vue Outdated
@gaspergrom
Copy link
Copy Markdown
Contributor Author

I think in terms of the UI there are 2 things missing:

  1. Required icon "*" missing in email
  2. Deactivated state of drawer should be opaque, disabling the fields

Could you take a look at it? 🙏

Hey email has red star there so it marks that its required and if not active all fields are already disabled.

Copy link
Copy Markdown
Contributor

@joanagmaia joanagmaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gaspergrom gaspergrom merged commit 44fc413 into feature/eagle-eye-2 Feb 14, 2023
@gaspergrom gaspergrom deleted the feature/email-digest-C-750 branch February 14, 2023 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature Created by Linear-GitHub Sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants