Skip to content

Base iterator looses dynamic endpoints information on consecutive runs#50

Merged
epipav merged 6 commits intobugfix/github-check-repo-availablefrom
bugfix/iterators-dynamic-endpoints
Sep 12, 2022
Merged

Base iterator looses dynamic endpoints information on consecutive runs#50
epipav merged 6 commits intobugfix/github-check-repo-availablefrom
bugfix/iterators-dynamic-endpoints

Conversation

@epipav
Copy link
Copy Markdown
Collaborator

@epipav epipav commented Sep 12, 2022

Changes proposed ✍️

  • Currently, dynamic endpoints are lost when we spawn a new lambda on 15 min. limit reached.
  • Iterators now keep an endpoints state for parsing the remaining endpoints.
  • This state is passed to new executions when lambda limit is reached. This helps retaining the dynamic endpoints during previous iterations

Checklist ✅

  • Label appropriately with type:feature 🚀, type:enhancement ✨, type:bug 🐞, or type:documentation 📜.
  • Tests are passing.
  • New backend functionality has been unit-tested.
  • Environment variables have been updated
    • Front-end: frontend/.env.dist
    • Backend: backend/.env.dist, backend/.env.dist.staging, backend/.env.dist.staging.
    • Configuration docs have been updated.
    • Team members only: update environment variables in Password manager and update the team
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.
  • All changes have been tested in a staging site.
  • All changes are working locally running crowd.dev's Docker local environment.

@epipav epipav requested a review from joanreyero September 12, 2022 08:10
@epipav epipav changed the title Bugfix/iterators dynamic endpoints Base iterator looses dynamic endpoints information on consecutive runs Sep 12, 2022
@epipav epipav merged commit 06d3059 into bugfix/github-check-repo-available Sep 12, 2022
@epipav epipav deleted the bugfix/iterators-dynamic-endpoints branch September 12, 2022 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant