Skip to content

Make eagle eye form components reusable#524

Merged
joanagmaia merged 4 commits into
feature/eagle-eye-2from
improvement/eagle-eye-form
Feb 14, 2023
Merged

Make eagle eye form components reusable#524
joanagmaia merged 4 commits into
feature/eagle-eye-2from
improvement/eagle-eye-form

Conversation

@joanagmaia
Copy link
Copy Markdown
Contributor

@joanagmaia joanagmaia commented Feb 13, 2023

Changes proposed ✍️

  • Create reusable component for platforms and published date
  • Fix settings drawer keywords delete button UI
  • Fix list loading state when reset storage is set to true
  • Fix logic when changing between tabs. Refactor eagle eye store so that state is not shared between tabs

Checklist ✅

  • Label appropriately with Feature, Enhancement, or Bug.
  • Tests are passing.
  • New backend functionality has been unit-tested.
  • Environment variables have been updated:
    • Local frontend configuration: frontend/.env.dist.local, frontend/.env.dist.composed.
    • Local backend: backend/.env.dist.local, backend/.env.dist.composed.
    • Configuration docs have been updated.
    • Team members only: update environment variables in override, staging and production env. files and trigger update config script.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.
  • All changes have been tested in a staging site.
  • All changes are working locally running crowd.dev's Docker local environment.

@joanagmaia joanagmaia self-assigned this Feb 13, 2023
@joanagmaia joanagmaia added the Improvement Created by Linear-GitHub Sync label Feb 13, 2023
@joanagmaia joanagmaia merged commit fd4e569 into feature/eagle-eye-2 Feb 14, 2023
@joanagmaia joanagmaia deleted the improvement/eagle-eye-form branch February 14, 2023 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Improvement Created by Linear-GitHub Sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants