Skip to content

Fix settings update action#526

Merged
gaspergrom merged 1 commit into
feature/eagle-eye-2from
bug/settings-update-action
Feb 14, 2023
Merged

Fix settings update action#526
gaspergrom merged 1 commit into
feature/eagle-eye-2from
bug/settings-update-action

Conversation

@joanagmaia
Copy link
Copy Markdown
Contributor

Changes proposed ✍️

  • When updating settings (drawer, onboarding), the drawer should only be while the settings/user is being updated. It should not have to wait for fetching

Checklist ✅

  • Label appropriately with Feature, Enhancement, or Bug.
  • Tests are passing.
  • New backend functionality has been unit-tested.
  • Environment variables have been updated:
    • Local frontend configuration: frontend/.env.dist.local, frontend/.env.dist.composed.
    • Local backend: backend/.env.dist.local, backend/.env.dist.composed.
    • Configuration docs have been updated.
    • Team members only: update environment variables in override, staging and production env. files and trigger update config script.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.
  • All changes have been tested in a staging site.
  • All changes are working locally running crowd.dev's Docker local environment.

@joanagmaia joanagmaia added the Bug Created by Linear-GitHub Sync label Feb 14, 2023
@joanagmaia joanagmaia self-assigned this Feb 14, 2023
@gaspergrom gaspergrom merged commit e6b28aa into feature/eagle-eye-2 Feb 14, 2023
@gaspergrom gaspergrom deleted the bug/settings-update-action branch February 14, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Created by Linear-GitHub Sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants