Eagle eye drawers fixes#536
Merged
Merged
Conversation
gaspergrom
changed the title
joanagmaia
approved these changes
Feb 15, 2023
Contributor
joanagmaia
left a comment
joanagmaia
left a comment
There was a problem hiding this comment.
Just left some comments for things that I believe were left behind
Other than that thanks for the great work!
This will save us a lot of time in feature
| module: 'eagleEye' | ||
| }, | ||
| beforeEnter: async (to, _from, next) => { | ||
| console.log('/eagle-eye') |
Contributor
There was a problem hiding this comment.
I think this might be by mistake? Could you delete logging?
|
|
||
| <script> | ||
| export default { | ||
| name: 'CrEagleEyeSetting' |
Contributor
There was a problem hiding this comment.
Could you delete this one for now maybe? While we are not using a new convention?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed ✍️
update button disabled if form not changed on feed settings and email digest settings
disable if email digest form is not valid
fix styling on feed settings select
migrate to new validation model
all platforms are selected by default
default date range is last 7 days
message above platforms
Screenshots (front-end changes only)
Checklist ✅
Feature,Enhancement, orBug.frontend/.env.dist.local,frontend/.env.dist.composed.backend/.env.dist.local,backend/.env.dist.composed.