Allow to hide/show attributes#572
Merged
Merged
Conversation
joanreyero
reviewed
Feb 24, 2023
Contributor
There was a problem hiding this comment.
The code and functionality look great!
A couple of suggested changes:
- I think the eye icon is mixed up. Notion has the "on" eye when the attribute is visible and the off eye when it is not. I think that makes more sense. When I visited a member for the first time, it looked like all attributes were hidden.
-
I would grey out the icon when it is hidden, to give more visibility (see the notion screenshot).
-
I would make the icons a bit smaller, and the default a bit lighter, but this is more personal preference 😀
-
I think that the Hidden subtitle adds some value in Notion, I would suggest to add it.
gaspergrom
approved these changes
Feb 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Changes proposed ✍️
record. For new members form it will only be shown attributes that can be deleted. For edit form, all member's attributes will be displayedget-custom-attribuetesso thatshowproperty can be considered or not when filtering depending on the use case. For members filters (considered), for forms (not considered)Screenshots (front-end changes only)
Checklist ✅
Feature,Enhancement, orBug.frontend/.env.dist.local,frontend/.env.dist.composed.backend/.env.dist.local,backend/.env.dist.composed.