Skip to content

Allow to hide/show attributes#572

Merged
joanagmaia merged 4 commits into
mainfrom
improvement/hideable-attributes
Feb 24, 2023
Merged

Allow to hide/show attributes#572
joanagmaia merged 4 commits into
mainfrom
improvement/hideable-attributes

Conversation

@joanagmaia
Copy link
Copy Markdown
Contributor

Changes proposed ✍️

  • Add show/hide button next to attribute's field -> Only render the button if attribute cannot be deleted
  • Once the button is clicked, the user is prompted with a message to confirm their action. Once the action is confirmed, the attribute will either be shown/hidden from member's profiles
  • Fix Attributes section in New members -> The filtering for custom attributes was throwing an error for new member form, because there was no record. For new members form it will only be shown attributes that can be deleted. For edit form, all member's attributes will be displayed
  • Refactor get-custom-attribuetes so that show property can be considered or not when filtering depending on the use case. For members filters (considered), for forms (not considered)

Screenshots (front-end changes only)

Screenshot 2023-02-24 at 11 57 17

Checklist ✅

  • Label appropriately with Feature, Enhancement, or Bug.
  • Tests are passing.
  • New backend functionality has been unit-tested.
  • Environment variables have been updated:
    • Local frontend configuration: frontend/.env.dist.local, frontend/.env.dist.composed.
    • Local backend: backend/.env.dist.local, backend/.env.dist.composed.
    • Configuration docs have been updated.
    • Team members only: update environment variables in override, staging and production env. files and trigger update config script.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.
  • All changes have been tested in a staging site.
  • All changes are working locally running crowd.dev's Docker local environment.

@joanagmaia joanagmaia added the Improvement Created by Linear-GitHub Sync label Feb 24, 2023
@joanagmaia joanagmaia self-assigned this Feb 24, 2023
Copy link
Copy Markdown
Contributor

@joanreyero joanreyero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code and functionality look great!

A couple of suggested changes:

  • I think the eye icon is mixed up. Notion has the "on" eye when the attribute is visible and the off eye when it is not. I think that makes more sense. When I visited a member for the first time, it looked like all attributes were hidden.

Screenshot 2023-02-24 at 14 17 56

  • I would grey out the icon when it is hidden, to give more visibility (see the notion screenshot).

  • I would make the icons a bit smaller, and the default a bit lighter, but this is more personal preference 😀

  • I think that the Hidden subtitle adds some value in Notion, I would suggest to add it.

@joanagmaia joanagmaia merged commit 5e7010c into main Feb 24, 2023
@joanagmaia joanagmaia deleted the improvement/hideable-attributes branch February 24, 2023 17:38
joanreyero pushed a commit that referenced this pull request Apr 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Improvement Created by Linear-GitHub Sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants