Add limit to autocomplete member's dropdown#587
Merged
Conversation
joanreyero
reviewed
Feb 28, 2023
Contributor
joanreyero
left a comment
There was a problem hiding this comment.
Thanks for handling this so quickly! Added a couple of questions
47e7641 to
f414051
Compare
f414051 to
82e00b2
Compare
Contributor
Author
|
@joanreyero just updated the PR so that we have a limit of 20 results in the dropdown |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed ✍️
platform-autocomplete-input.vuemember-autocomplete-inputcomponent to simplify it's purpose. Directly useautocomplete-one-inputcomponent. Create/addtotalFnmethod toautocomplete-one-inputto fetch the total number of resources within the dropdown (autocomplete endpoint does not gives us this information)tag-autocomplete-inputas it was not using some of its components/dataautocomplete-one-inputto load results with lazy loadingChecklist ✅
Feature,Enhancement, orBug.frontend/.env.dist.local,frontend/.env.dist.composed.backend/.env.dist.local,backend/.env.dist.composed.