Skip to content

Allow to reenrich members#594

Merged
joanagmaia merged 3 commits into
mainfrom
improvement/re-enrich-member
Mar 2, 2023
Merged

Allow to reenrich members#594
joanagmaia merged 3 commits into
mainfrom
improvement/re-enrich-member

Conversation

@joanagmaia
Copy link
Copy Markdown
Contributor

Changes proposed ✍️

  • Support highlightedInfo in horizontal dialogs
  • Refactor member-dropdown. If member was already enriched, show Re-enrich member
  • Refactor member-list-toolbar:
    • Add computed label for enrichment option. Re-enrich members if all selected members were already enriched. Enrich members for all other scenarios
    • If all selected members we already enrich, trigger the action immediately after click
    • If all selected members were not enriched and are elegible, trigger the action immediately after click
    • If some of the selected members are not elegible and were already enriched, show modal with warning regarding both constraints
    • If some of the selected members were already enriched, show modal with warning

Screenshots (front-end changes only)

Screenshot 2023-03-01 at 17 41 47
Screenshot 2023-03-01 at 17 41 39
Screenshot 2023-03-01 at 17 41 24
Screenshot 2023-03-01 at 17 41 19
Screenshot 2023-03-01 at 17 41 10

Checklist ✅

  • Label appropriately with Feature, Enhancement, or Bug.
  • Tests are passing.
  • New backend functionality has been unit-tested.
  • Environment variables have been updated:
    • Local frontend configuration: frontend/.env.dist.local, frontend/.env.dist.composed.
    • Local backend: backend/.env.dist.local, backend/.env.dist.composed.
    • Configuration docs have been updated.
    • Team members only: update environment variables in override, staging and production env. files and trigger update config script.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.
  • All changes have been tested in a staging site.
  • All changes are working locally running crowd.dev's Docker local environment.

@joanagmaia joanagmaia added the Improvement Created by Linear-GitHub Sync label Mar 1, 2023
@joanagmaia joanagmaia requested a review from gaspergrom March 1, 2023 17:49
@joanagmaia joanagmaia self-assigned this Mar 1, 2023
@joanagmaia joanagmaia force-pushed the improvement/re-enrich-member branch from 654630c to 0f4b8b1 Compare March 1, 2023 17:51
@joanagmaia joanagmaia merged commit 89cd415 into main Mar 2, 2023
@joanagmaia joanagmaia deleted the improvement/re-enrich-member branch March 2, 2023 15:26
joanreyero pushed a commit that referenced this pull request Apr 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Improvement Created by Linear-GitHub Sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants