Skip to content

Fix onboarding event property name #662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joanagmaia merged 1 commit into from
Mar 17, 2023
Merged

Fix onboarding event property name #662

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions frontend/src/modules/dashboard/components/dashboard-guides.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ const dismissGuides = () => {
cancelButtonText: 'Cancel'
}).then(() => {
EventTrackingService.track({
event: 'Onboarding Guide dismissed'
name: 'Onboarding Guide dismissed'
})

onboardingGuidesDismissed.value = true
Expand Down Expand Up @@ -221,7 +221,7 @@ const onGuideOpen = (guide) => {
selectedGuide.value = guide

EventTrackingService.track({
event: 'Onboarding Guide details clicked',
name: 'Onboarding Guide details clicked',
properties: {
step: guide.key
}
Expand Down
4 changes: 2 additions & 2 deletions frontend/src/modules/dashboard/components/guide/dashboard-guide-eagle-eye-modal.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ const modalOpened = computed({
// Track event on modal dismiss
if (props.modelValue) {
EventTrackingService.track({
event: 'Eagle Eye Guide dismissed'
name: 'Eagle Eye Guide dismissed'
})
}

Expand All @@ -103,7 +103,7 @@ const closing = () => {

const trackBtnClick = () => {
EventTrackingService.track({
event: 'Eagle Eye Guide button clicked'
name: 'Eagle Eye Guide button clicked'
})
}
</script>
2 changes: 1 addition & 1 deletion frontend/src/modules/dashboard/components/guide/dashboard-guide-item.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ const emit = defineEmits(['open'])

const trackBtnClick = (step) => {
EventTrackingService.track({
event: 'Onboarding Guide button clicked',
name: 'Onboarding Guide button clicked',
properties: {
step
}
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/modules/dashboard/components/guide/dashboard-guide-modal.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ const modalOpened = computed({

const trackBtnClick = (step) => {
EventTrackingService.track({
event: 'Onboarding Guide button clicked',
name: 'Onboarding Guide button clicked',
properties: {
step
}
Expand Down