Skip to content

Support excluding filters#720

Merged
joanagmaia merged 4 commits intomainfrom
improvement/support-exclude-filters
Apr 5, 2023
Merged

Support excluding filters#720
joanagmaia merged 4 commits intomainfrom
improvement/support-exclude-filters

Conversation

@joanagmaia
Copy link
Copy Markdown
Contributor

@joanagmaia joanagmaia commented Apr 3, 2023

Changes proposed ✍️

  • Add a toggle for all filters (except Custom Attributes in Member's page) for Include/Exclude. By default all filters have Include selected
  • In build-api-payload.js, if filter has include set to false, add a wrapper of the filter with not operator. It will filter for the opposite of the include

Screenshots (front-end changes only)

Screenshot 2023-04-03 at 17 03 12
Screenshot 2023-04-03 at 17 03 09

Checklist ✅

  • Label appropriately with Feature, Enhancement, or Bug.
  • Tests are passing.
  • New backend functionality has been unit-tested.
  • Environment variables have been updated:
    • Local frontend configuration: frontend/.env.dist.local, frontend/.env.dist.composed.
    • Local backend: backend/.env.dist.local, backend/.env.dist.composed.
    • Configuration docs have been updated.
    • Team members only: update environment variables in override, staging and production env. files and trigger update config script.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.
  • All changes have been tested in a staging site.
  • All changes are working locally running crowd.dev's Docker local environment.

@joanagmaia joanagmaia added the Improvement Created by Linear-GitHub Sync label Apr 3, 2023
@joanagmaia joanagmaia self-assigned this Apr 3, 2023
@joanagmaia joanagmaia requested a review from gaspergrom April 4, 2023 15:44
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 5, 2023

CLA assistant check
All committers have signed the CLA.

@joanagmaia joanagmaia merged commit cb94714 into main Apr 5, 2023
@joanagmaia joanagmaia deleted the improvement/support-exclude-filters branch April 5, 2023 10:10
joanreyero pushed a commit that referenced this pull request Apr 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Improvement Created by Linear-GitHub Sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants