Keep track of activity's channels#721
Merged
joanreyero merged 9 commits intolinuxfoundation:mainfrom Apr 12, 2023
Merged
Conversation
joanreyero
reviewed
Apr 4, 2023
Contributor
joanreyero
left a comment
There was a problem hiding this comment.
Thanks a lot for your contribution! 🤩🙏
The changes look great, and the new functionality will be super appreciated.
I added a couple of nitpicks. Once they are addressed, I will prepare a query to change past data and we can merge!
| } | ||
|
|
||
| const activityChannels = await SettingsRepository.getActivityChannels(options) | ||
| // const channelKey = getCleanString(data.channel) Maybe this is required? |
Contributor
There was a problem hiding this comment.
Nit: I don't think this is needed. Can you remove it? 😊 so we don't have commented code
| ) | ||
| } | ||
|
|
||
| const activityChannels = await SettingsRepository.getActivityChannels(options) |
Contributor
There was a problem hiding this comment.
Nit: the getActivityChannels function is not async. No need to await.
joanreyero
pushed a commit
that referenced
this pull request
Apr 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed ✍️
This PR contains code for the following.
Checklist ✅
Feature,Enhancement, orBug.frontend/.env.dist.local,frontend/.env.dist.composed.backend/.env.dist.local,backend/.env.dist.composed.