Skip to content

Fix discord channels semantics #726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joanreyero merged 2 commits into from
Apr 5, 2023
Merged

Fix discord channels semantics #726

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d20eac
Changed integration to always put channel as channel and keep the chi…
Apr 5, 2023
2ce2761
FIxed channel layout
Apr 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions backend/src/serverless/integrations/services/integrations/discordIntegrationService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -525,9 +525,9 @@ export class DiscordIntegrationService extends IntegrationServiceBase {
? DiscordIntegrationService.replaceMentions(record.content, record.mentions)
: '',
url: `https://discordapp.com/channels/${channel.guild_id}/${channel.id}/${record.id}`,
channel: channel.name,
channel: parentChannel || channel.name,
attributes: {
parentChannel,
childChannel: parentChannel ? channel.name : undefined,
thread: isThread,
reactions: record.reactions ? record.reactions : [],
attachments: record.attachments ? record.attachments : [],
Expand Down
4 changes: 2 additions & 2 deletions backend/src/types/activityTypes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,10 +293,10 @@ export const DEFAULT_ACTIVITY_TYPE_SETTINGS: DefaultActivityTypes = {
[DiscordtoActivityType.THREAD_MESSAGE]: {
display: {
default:
'replied to a message in thread <span class="text-brand-500 truncate max-w-2xs">#{channel}</span> -> <span class="text-brand-500">{attributes.parentChannel}</span>',
'replied to a message in thread <span class="text-brand-500 truncate max-w-2xs">#{channel}</span> -> <span class="text-brand-500">{attributes.childChannel}</span>',
short: 'replied to a message',
channel:
'<span class="text-brand-500 truncate max-w-2xs">thread #{channel}</span> -> <span class="text-brand-500">#{attributes.parentChannel}</span>',
'<span class="text-brand-500 truncate max-w-2xs">thread #{channel}</span> -> <span class="text-brand-500">#{attributes.childChannel}</span>',
},
isContribution: DiscordGrid.message.isContribution,
},
Expand Down