Skip to content

Redundant type sanitization on creating activity types#737

Merged
epipav merged 2 commits intomainfrom
improvement/activity-types-redundant-sanitize
Apr 17, 2023
Merged

Redundant type sanitization on creating activity types#737
epipav merged 2 commits intomainfrom
improvement/activity-types-redundant-sanitize

Conversation

@epipav
Copy link
Copy Markdown
Collaborator

@epipav epipav commented Apr 10, 2023

Changes proposed ✍️

  • Removes redundant type sanitization on creating activity type mapping

Checklist ✅

  • Label appropriately with Feature, Enhancement, or Bug.
  • Tests are passing.
  • New backend functionality has been unit-tested.
  • Environment variables have been updated:
    • Local frontend configuration: frontend/.env.dist.local, frontend/.env.dist.composed.
    • Local backend: backend/.env.dist.local, backend/.env.dist.composed.
    • Configuration docs have been updated.
    • Team members only: update environment variables in override, staging and production env. files and trigger update config script.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.
  • All changes have been tested in a staging site.
  • All changes are working locally running crowd.dev's Docker local environment.

@epipav epipav marked this pull request as ready for review April 10, 2023 08:38
@epipav epipav self-assigned this Apr 10, 2023
@epipav epipav added the Improvement Created by Linear-GitHub Sync label Apr 10, 2023
@epipav epipav merged commit 88c236e into main Apr 17, 2023
@epipav epipav deleted the improvement/activity-types-redundant-sanitize branch April 17, 2023 14:04
joanreyero pushed a commit that referenced this pull request Apr 29, 2023
Co-authored-by: Joan Reyero <joan@crowd.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Improvement Created by Linear-GitHub Sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant