Skip to content

Feature: number of open source contributions attribute#768

Merged
joanreyero merged 3 commits intolinuxfoundation:mainfrom
akhill10:feat/attribute-number-of-oss-contributions
Apr 17, 2023
Merged

Feature: number of open source contributions attribute#768
joanreyero merged 3 commits intolinuxfoundation:mainfrom
akhill10:feat/attribute-number-of-oss-contributions

Conversation

@akhill10
Copy link
Copy Markdown
Contributor

@akhill10 akhill10 commented Apr 16, 2023

Changes proposed ✍️

  • number of open source contributions was added to the profile view of each member, the list page (app.crowd.dev/members), and filterable and sortable.
  • Backend changes were done to both the versions of findAndCountAll and findAndCountAllv2 in the backend/src/database/repositories/memberRepository.ts.
  • Added Unit tests for findAndCountAllv2 which doesn't exist earlier

Fixes: #478
/claim #478

  • Screenshots (front-end changes only)

# of open source contributions

Screenshot 2023-04-16 at 6 05 55 PM

Screenshot 2023-04-16 at 6 06 23 PM

Checklist ✅

  • Label appropriately with Feature, Enhancement, or Bug.
  • Tests are passing.
  • New backend functionality has been unit-tested.
  • Environment variables have been updated:
    • Local frontend configuration: frontend/.env.dist.local, frontend/.env.dist.composed.
    • Local backend: backend/.env.dist.local, backend/.env.dist.composed.
    • Configuration docs have been updated.
    • Team members only: update environment variables in override, staging and production env. files and trigger update config script.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.
  • All changes have been tested in a staging site.
  • All changes are working locally running crowd.dev's Docker local environment.

@jonathimer
Copy link
Copy Markdown
Contributor

@akhill10 Thanks for your contribution! We will review it and get back asap.

@akhill10
Copy link
Copy Markdown
Contributor Author

@jonathimer Updated the PR with a prettier fix and a few tests got failed. So updated the test cases as well.

Copy link
Copy Markdown
Contributor

@joanreyero joanreyero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks a ton for doing this 🤩

@joanreyero joanreyero merged commit 257bd14 into linuxfoundation:main Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[C-597] Add attribute: # of open source contributions

3 participants