Skip to content

Fix displaying of activity types#769

Merged
gaspergrom merged 4 commits intomainfrom
bugfix/empty-filters-custom-activities
Apr 18, 2023
Merged

Fix displaying of activity types#769
gaspergrom merged 4 commits intomainfrom
bugfix/empty-filters-custom-activities

Conversation

@gaspergrom
Copy link
Copy Markdown
Contributor

Changes proposed ✍️

  • fix displaying of custom activity types
  • upgraded formbricks version

Screenshots (front-end changes only)

image

image

Checklist ✅

  • Label appropriately with Feature, Enhancement, or Bug.
  • Tests are passing.
  • New backend functionality has been unit-tested.
  • Environment variables have been updated:
    • Local frontend configuration: frontend/.env.dist.local, frontend/.env.dist.composed.
    • Local backend: backend/.env.dist.local, backend/.env.dist.composed.
    • Configuration docs have been updated.
    • Team members only: update environment variables in override, staging and production env. files and trigger update config script.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.
  • All changes have been tested in a staging site.
  • All changes are working locally running crowd.dev's Docker local environment.

@gaspergrom gaspergrom added the Bug Created by Linear-GitHub Sync label Apr 17, 2023
@gaspergrom gaspergrom requested a review from joanagmaia April 17, 2023 07:13
@gaspergrom gaspergrom self-assigned this Apr 17, 2023
@gaspergrom gaspergrom marked this pull request as ready for review April 17, 2023 07:13
Copy link
Copy Markdown
Contributor

@joanagmaia joanagmaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!
Just noticed that in the Member's page, the activity type filter does not have Custom activities in the filter. Could you also take a look at that?

Comment thread frontend/src/modules/dashboard/components/activity/dashboard-activity-types.vue Outdated
Comment thread frontend/src/modules/dashboard/components/activity/dashboard-activity-types.vue Outdated
@gaspergrom gaspergrom requested a review from joanagmaia April 17, 2023 15:01
Copy link
Copy Markdown
Contributor

@joanagmaia joanagmaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also take a look at this?

Just noticed that in the Member's page, the activity type filter does not have Custom activities in the filter

@gaspergrom gaspergrom requested a review from joanagmaia April 18, 2023 07:07
@gaspergrom gaspergrom merged commit c95e944 into main Apr 18, 2023
@gaspergrom gaspergrom deleted the bugfix/empty-filters-custom-activities branch April 18, 2023 08:27
joanreyero pushed a commit that referenced this pull request Apr 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Created by Linear-GitHub Sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants