Fix count values on platform selection on the home page#781
Fix count values on platform selection on the home page#781joanagmaia merged 5 commits intolinuxfoundation:mainfrom
Conversation
joanagmaia
left a comment
There was a problem hiding this comment.
Once again thanks so much for the contribution 😄
Almost there! Just a couple remarks:
- Please fix eslint related issues. You can see that one of the build failed in PR
- What you updated in the
actions.jsfile is good 👌 But I believe you are also missing for Conversation and Organizations. So the same way you updated forgetActivitiesCountandgetMembersCount, you should also update forgetConversationCount, andgetOrganizationsCount
|
@joanagmaia thanks for the feedback. |
You are right, it should have been better detailed, apologies for that. I'll take care of updating the issue description to make sure that it also contains for organizations and conversations. |
|
@joanagmaia I'm not sure how to use the conversation. Can you help? There's no visual representation |
joanagmaia
left a comment
There was a problem hiding this comment.
@peoray you are right Conversation does not have a visual representation, that's why it was commented. I missed that one, sorry about the confusion.
Could you undo the changes for Conversations? Other than that looks good to me for Members, Organizations and Activities. Once you undo for Conversations I'll approve it
|
@joanagmaia Resolved |
Changes proposed ✍️
Fix count values on platform selection on the home page
What
🤖 Generated by Copilot at b43a433
/claim #752
Added platform filter and improved loading indicator for dashboard widget header. The filter allows users to see platform-specific data, and the indicator shows the correct loading state for the total counts.
Fixes #752
🤖 Generated by Copilot at b43a433
Why
How
🤖 Generated by Copilot at b43a433
totalLoadingprop instead ofloadingprop forapp-loadingcomponent in dashboard widget header to match total counts of activities and members (link)platformfilter from state toActivityService.listandMemberService.listmethods in dashboard store actions to get platform-specific counts of activities and members for dashboard widget header (link, link)Checklist ✅
Feature,Improvement, orBug.