Skip to content

Add number of activities column to all member views#789

Merged
joanagmaia merged 2 commits intolinuxfoundation:mainfrom
peoray:activities-column-member-view
Apr 24, 2023
Merged

Add number of activities column to all member views#789
joanagmaia merged 2 commits intolinuxfoundation:mainfrom
peoray:activities-column-member-view

Conversation

@peoray
Copy link
Copy Markdown
Contributor

@peoray peoray commented Apr 20, 2023

Changes proposed ✍️

Add number of activities column to all member views

Fixes #779

What

🤖 Generated by Copilot at 33cdb12

Added a new frontend feature to show member activities in the crowd. The feature involves a new activities column in the member table and some changes in the frontend/src/modules/member/store/state.js file.

🤖 Generated by Copilot at 33cdb12

Activities of the crowd, a new column of power
Revealing the secrets of the members, their deeds and their hours
Who is the most active, who is the most slack?
Who will rise to the challenge, who will fall to the back?

Why

How

🤖 Generated by Copilot at 33cdb12

  • Add a new column for activity count to the member table views (link, link, link, link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@joanagmaia joanagmaia self-requested a review April 21, 2023 10:10
Copy link
Copy Markdown
Contributor

@joanagmaia joanagmaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @peoray, thanks for this work!
The columns in members state was actually being used to render extraColumns in specific views. That's why only the most-engaged view had it in the columns array.

Since the goal of this issue is to add it to all columns, I think there is a better approach to it. Here are my changes request:

  • Remove all activityCount columns from members state. columns will just be an empty array for now.
  • In member-list-table.vue component, please add the new column using <el-table-column /> component.
  • To render the value of the activityCount please make sure to:
    • Use formatNumber utils from number.js. This will format number in a friendly way

@peoray
Copy link
Copy Markdown
Contributor Author

peoray commented Apr 21, 2023

@joanagmaia to be clear, do I leave the most-engaged as it is or also make it an empty array?
And in the member-list-table file, do I keep the extraColums column or remove it?

@joanagmaia joanagmaia added Improvement Created by Linear-GitHub Sync Contributor Created by Linear-GitHub Sync labels Apr 21, 2023
@joanagmaia
Copy link
Copy Markdown
Contributor

@joanagmaia to be clear, do I leave the most-engaged as it is or also make it an empty array? And in the member-list-table file, do I keep the extraColums column or remove it?

Good point on the extraColumns. From what I saw we would no longer be using it, so yeah you can remove from the component and columns from the state. This also answers your other question, most-engaged will no longer have this configuration as well

@peoray
Copy link
Copy Markdown
Contributor Author

peoray commented Apr 21, 2023

@joanagmaia Updated.

Copy link
Copy Markdown
Contributor

@joanagmaia joanagmaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@joanagmaia joanagmaia merged commit be1fef1 into linuxfoundation:main Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Contributor Created by Linear-GitHub Sync Improvement Created by Linear-GitHub Sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[C-1201] Add "# of activities" column to all views

2 participants