Skip to content

Member filter tests #790

Merged
gaspergrom merged 14 commits intomainfrom
improvement/member-filter-test
May 10, 2023
Merged

Member filter tests #790
gaspergrom merged 14 commits intomainfrom
improvement/member-filter-test

Conversation

@gaspergrom
Copy link
Copy Markdown
Contributor

@gaspergrom gaspergrom commented Apr 20, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at 9f71bef

This pull request adds id and CSS class attributes to various elements in the frontend components for testing purposes. It also adds a new ESLint rule for consistent spacing in Vue templates. Finally, it adds several new end-to-end test files for the member list filters, covering different filter criteria and options.

🤖 Generated by Copilot at 9f71bef

ESLint rule added
Testing filters and styles
Autumn leaves of code

Why

How

🤖 Generated by Copilot at 9f71bef

  • Add new ESLint rule for HTML closing brackets spacing in Vue templates (link)
  • Add new CSS classes for testing purposes to member list table components (link, link, link)
  • Add id attributes for testing purposes to filter dropdown and filter list item components (link, link, link, link, link)
  • Add id attribute for testing purposes to pagination sorter component (link)
  • Refactor auth tests to export them as a default function with parameters (link, link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@gaspergrom gaspergrom added the Improvement Created by Linear-GitHub Sync label Apr 20, 2023
@gaspergrom gaspergrom requested a review from joanagmaia April 20, 2023 15:53
@gaspergrom gaspergrom self-assigned this Apr 20, 2023
@gaspergrom gaspergrom marked this pull request as ready for review April 21, 2023 14:39
Comment thread frontend/tests/e2e/member/filter/active-on.js Outdated
Comment thread frontend/tests/e2e/member/filter/active-on.js
Comment thread frontend/tests/e2e/member/filter/activity-type.js
Copy link
Copy Markdown
Contributor

@joanagmaia joanagmaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaspergrom gaspergrom merged commit e272aaf into main May 10, 2023
@gaspergrom gaspergrom deleted the improvement/member-filter-test branch May 10, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Improvement Created by Linear-GitHub Sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants