[C-145] [issue-298] Change all tab title to match page titles#819
Merged
joanagmaia merged 5 commits intolinuxfoundation:mainfrom May 11, 2023
Merged
Conversation
|
|
jonathimer
requested review from
joanagmaia and
joanreyero
and removed request for
joanagmaia
joanagmaia
requested changes
May 9, 2023
Contributor
joanagmaia
left a comment
joanagmaia
left a comment
There was a problem hiding this comment.
Hey @keshari1arya 👋
Thank you so much for your contribution 🙏 Great to see a new contributor joining our community 😄
Just left a few comments, but it's already looking great.
Another thing that also needs update:
- If you run the app you will notice some errors and warnings related to eslint. Do you mind fixing those as well? You have it in multiple files but you'll be able to see them in the logs of your terminal. You can also configure your IDE to have eslint set to format/fix on save. Let me know if you run into any issues fixing these
joanagmaia
reviewed
May 11, 2023
joanagmaia
added
Contributor
Contributor
|
Thanks for your first contribution @keshari1arya 🙌⭐️🚀 |
Contributor
Author
|
Thank you @jonathimer and @joanagmaia for giving me this opportunity. Aiming to not stop contributing. Cheers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed ✍️
Change browser tab titles to match all page titles #298
What
🤖 Generated by Copilot at 401b845
Added
titleproperties to themetaobjects of various routes in different modules to enable dynamic document titles based on the current route. This is part of a feature to improve the user experience and SEO of the web pages. Implemented a global router guard inApp.vueto set the document title according to themeta.titleproperty of each route.
🤖 Generated by Copilot at 401b845
Why
How
🤖 Generated by Copilot at 401b845
beforeEachguard for the router inApp.vuethat sets the document title based on themeta.titleproperty of each route or defaults tocrowd.dev(link)titleproperty to themetaobject of each route in the following modules:activity,auth,integration,member,onboard,organization,report,settings,task,community-help-center, andeagle-eye(link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link)Checklist ✅
Feature,Improvement, orBug.