Skip to content

Slack notifications automation#833

Merged
gaspergrom merged 17 commits intomainfrom
feature/automation-slack
May 9, 2023
Merged

Slack notifications automation#833
gaspergrom merged 17 commits intomainfrom
feature/automation-slack

Conversation

@gaspergrom
Copy link
Copy Markdown
Contributor

@gaspergrom gaspergrom commented May 5, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at 97819ba

This pull request adds the Slack integration and automation feature to the backend project. It adds new dependencies, configuration, models, migrations, repositories, and API routes to support the feature. It also adds a name property to the automation model and entity, and fixes a potential bug in the apiResponseHandler.ts file. It modifies the settingsRepository.ts, automationRepository.ts, and memberRepository.ts files to include new methods and associations. It uses the html-to-mrkdwn-ts package to convert HTML content to markdown for Slack messages.

🤖 Generated by Copilot at 97819ba

Sing, O Muse, of the mighty pull request
That added the slack-notifier service to the app
And how the skilled developer, with html-to-mrkdwn-ts,
Transformed the HTML content to markdown with a snap.

Why

How

🤖 Generated by Copilot at 97819ba

  • Add slack-notifier configuration object and environment variables (link, link, link, link)
  • Add Slack integration and automation feature to the backend API (link, link, link, link, link, link, link)
  • Add name column to the automations table and model (link, link, link, link, link, link)
  • Fix potential bug in the error handling of the API response (link)
  • Order automation executions by executedAt column in descending order (link)
  • Include organization model as a nested association of the member model (link)
  • Add html-to-mrkdwn-ts package as a dependency to the backend project (link, link, link, link, link, link, link, link, link, link, link, link)
  • Remove some spaces between the imported modules and the curly braces in the settingsRepository.ts file (link)
  • Add console log statement for debugging in the _fill method of the settingsRepository.ts file (link)
  • Add migration files to undo the changes made by the previous migration files (link, link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@gaspergrom gaspergrom added the Feature Created by Linear-GitHub Sync label May 5, 2023
@gaspergrom gaspergrom requested review from epipav and joanagmaia May 5, 2023 09:29
@gaspergrom gaspergrom self-assigned this May 5, 2023
Copy link
Copy Markdown
Contributor

@joanagmaia joanagmaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great 😄
Left some comments with some issue I found

Comment thread frontend/src/modules/automation/components/action/slack-action.vue
Comment thread frontend/src/modules/automation/components/automation-form.vue
Comment thread frontend/src/modules/automation/components/list/automation-list-table.vue Outdated
Comment thread frontend/src/modules/automation/pages/automation-list-page.vue
Comment thread frontend/src/modules/automation/pages/automation-list-page.vue Outdated
Comment thread frontend/src/modules/automation/store/getters.js Outdated
Comment thread frontend/src/modules/automation/pages/automation-list-page.vue Outdated
@gaspergrom gaspergrom merged commit 3d953d3 into main May 9, 2023
@gaspergrom gaspergrom deleted the feature/automation-slack branch May 9, 2023 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature Created by Linear-GitHub Sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants