Skip to content

Twitter zapier connect flow#846

Merged
gaspergrom merged 1 commit intomainfrom
improvement/twitter-connect-zapier
May 10, 2023
Merged

Twitter zapier connect flow#846
gaspergrom merged 1 commit intomainfrom
improvement/twitter-connect-zapier

Conversation

@gaspergrom
Copy link
Copy Markdown
Contributor

@gaspergrom gaspergrom commented May 10, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at 20c34a5

This pull request replaces the Twitter connect drawer component with a modal component that uses the app-dialog component. It also adds a medium size option for the dialog component and removes the settings slot and prop from the Twitter connect component. These changes are part of a feature to improve the user experience and communication of the Twitter integration via Zapier.

🤖 Generated by Copilot at 20c34a5

app-dialog grows
Twitter modal replaces
drawer in the fall

Why

How

🤖 Generated by Copilot at 20c34a5

  • Add a new component for the Twitter connect modal that displays information and links about the Twitter integration via Zapier (link)
  • Replace the drawer component with the modal component in the Twitter connect component and remove the settings slot and prop (link)
  • Delete the unused twitter-connect-drawer.vue file (link)
  • Add a new modifier class for the dialog component to set a medium size for the max-width property and handle it in the computed class method (link, link)

image

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@gaspergrom gaspergrom added the Improvement Created by Linear-GitHub Sync label May 10, 2023
@gaspergrom gaspergrom requested a review from joanagmaia May 10, 2023 10:23
@gaspergrom gaspergrom self-assigned this May 10, 2023
@gaspergrom gaspergrom merged commit 0dddf39 into main May 10, 2023
@gaspergrom gaspergrom deleted the improvement/twitter-connect-zapier branch May 10, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Improvement Created by Linear-GitHub Sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants