Fix activity types display in dashboard#847
Merged
joanagmaia merged 1 commit intomainfrom May 10, 2023
Merged
Conversation
gaspergrom
approved these changes
May 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed ✍️
What
🤖 Generated by Copilot at 8301a72
The pull request improves the dashboard UI by enhancing the display of activity types from different sources and avoiding errors when the tenant name is missing. It uses
lodash.mergeand optional chaining indashboard-activity-types.vueanddashboard-page.vue.
🤖 Generated by Copilot at 8301a72
Why
How
🤖 Generated by Copilot at 8301a72
mergefunction fromlodashlibrary to combine default and custom activity types without overwriting or losing nested properties (link, link)currentTenant.nameexpression indashboard-page.vueto prevent errors ifcurrentTenantis null or undefined (link)Checklist ✅
Feature,Improvement, orBug.