Merged
Conversation
gaspergrom
approved these changes
May 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed ✍️
What
🤖 Generated by Copilot at 8bbfe51
This pull request adds support for custom platforms that are not part of the predefined list of integrations. It updates several components that display platform icons, names, or tooltips to handle the case where the platform config object or image is not found. It uses a generic user icon and the platform name as fallback values for such platforms. It also simplifies some conditional rendering logic and avoids hard-coding the 'other' platform name. The affected components are
platform-svg-icon.vue,platform.vue,member-identities.vue,member-merge-suggestions-details.vue,widget-activities-platform-content.vue,widget-activities-type.vue,widget-members-table.vue,community-help-center-table.vue, andplatform-list.vue.
🤖 Generated by Copilot at 8bbfe51
Why
How
🤖 Generated by Copilot at 8bbfe51
member-identities.vue,member-merge-suggestions-details.vue,platform-svg-icon.vue, andplatform.vuecomponents. (link, link, link, link)widget-activities-platform-content.vuecomponent. (link)widget-activities-type.vueandcommunity-help-center-table.vuecomponents by removing theplat !== 'other'condition and using theimagePropertiescomputed property instead. (link, link)buttons.scssandplatform.vuecomponents. (link, link)show-tooltipprop to theapp-platformandplatform.vuecomponents to enable the tooltip feature for the platform icons in different components that use them. (link, link)platformConfigcomputed property to theplatform-svg-icon.vuecomponent to reuse the computed property in the template and the script sections of the component. (link)platform-svg-icon.vuecomponent. (link)community-help-center-table.vuecomponent. (link)Checklist ✅
Feature,Improvement, orBug.