Skip to content

Fix activity type filter for empty types#869

Merged
joanagmaia merged 1 commit intomainfrom
bug/activity-type-filter-empty-types
May 16, 2023
Merged

Fix activity type filter for empty types#869
joanagmaia merged 1 commit intomainfrom
bug/activity-type-filter-empty-types

Conversation

@joanagmaia
Copy link
Copy Markdown
Contributor

@joanagmaia joanagmaia commented May 16, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at 0b35933

Improved the activity type field logic and display in activity-type-field.js. Used appConfig to check the git integration flag and filtered out irrelevant or duplicate types.

🤖 Generated by Copilot at 0b35933

To improve the activity field
The code filters out what's not real
It checks the appConfig flag
And the custom types we have
To show only the types that appeal

Why

How

🤖 Generated by Copilot at 0b35933

  • Filter out git activity type if git integration is not enabled (link, link) in activity-type-field.js

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@joanagmaia joanagmaia added the Bug Created by Linear-GitHub Sync label May 16, 2023
@joanagmaia joanagmaia requested a review from gaspergrom May 16, 2023 08:45
@joanagmaia joanagmaia self-assigned this May 16, 2023
@joanagmaia joanagmaia merged commit 9ebbcf8 into main May 16, 2023
@joanagmaia joanagmaia deleted the bug/activity-type-filter-empty-types branch May 16, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Created by Linear-GitHub Sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants