Filter relation management & query and store sync#873
Merged
gaspergrom merged 2 commits intofeature/filtersfrom May 17, 2023
Merged
Filter relation management & query and store sync#873gaspergrom merged 2 commits intofeature/filtersfrom
gaspergrom merged 2 commits intofeature/filtersfrom
Conversation
joanagmaia
approved these changes
May 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed ✍️
What
🤖 Generated by Copilot at 8ff6566
This pull request improves the filter functionality and appearance for the activity and member modules. It uses a shared utility function for parsing the query parameters and defines custom
apiFilterRendererfunctions for each filter to handle the API request logic. It also removes the<b>tags from the filter labels and adds a search filter for members. Additionally, it updates the style of the dropdown component to increase the contrast and usability.
🤖 Generated by Copilot at 8ff6566
Why
How
🤖 Generated by Copilot at 8ff6566
text-gray-900andcursor-defaultclasses to selected or focused dropdown items indropdown.scss(link)queryUrlParserByTypeutility function from shared filters module and use it for parsing query parameters for select and multiselect filter types in activity and member filter configs (link, link, link)apiFilterRendererproperty to activity and member filter configs to define the logic for rendering filter value for API request, and replacequeryRendererproperty where applicable (link, link, link, link, link, link, link, link, link, link, link, link, link, link)memberSearchFilterconfig tomain.tsto define the placeholder and theapiFilterRendererfunction for the search filter, which returns an array of filter conditions that match the search value with the member's display name or email (link, link)<b>tags fromitemLabelRendererfunctions in member filter configs to make the label consistent with other filters (link, link, link, link, link, link, link, link, link, link, link)Checklist ✅
Feature,Improvement, orBug.