Saved views#880
Merged
gaspergrom merged 2 commits intofeature/filtersfrom May 18, 2023
Merged
Conversation
joanagmaia
approved these changes
May 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed ✍️
What
🤖 Generated by Copilot at 7472c8c
This pull request refactors the member filter configurations by using shared helper functions and types from a common module, reducing code duplication and improving consistency. It also adds a new module for the member saved views configuration, which defines a list of hardcoded views and their settings, using enums and a common filter renderer.
🤖 Generated by Copilot at 7472c8c
Why
How
🤖 Generated by Copilot at 7472c8c
frontend/src/modules/member/config/saved-views/main.tsthat exports the member saved views configuration and a list of hardcoded views (link)frontend/src/modules/member/config/saved-views/views/all-members.tsandfrontend/src/modules/member/config/saved-views/views/influential.ts, that define the settings and filters for the view (link, link)frontend/src/modules/member/config/saved-views/settings/bot.tsandfrontend/src/modules/member/config/saved-views/settings/organization.ts, that define the enum type and the api filter renderer for the setting (link, link)frontend/src/modules/member/config/saved-views/settings/common/includeFilterRenderer.ts(link)frontend/src/modules/member/config/saved-views/settings/types/IncludeEnum.ts(link)Checklist ✅
Feature,Improvement, orBug.