Remove organization profiles and render as identities#884
Merged
joanagmaia merged 5 commits intomainfrom May 22, 2023
Merged
Conversation
gaspergrom
approved these changes
May 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed ✍️
What
🤖 Generated by Copilot at 5c5ca57
This pull request adds the Facebook integration for the frontend, allowing users to see and link the Facebook profiles of organizations. It also removes some redundant or unused components and attributes related to the organization enrichment and list. It modifies the files
integrations-config.js,organization-list-table.vue,organization-identities.vue,organization-enriched.vue,organization-view-aside.vue,buttons.scss, and adds the filesfacebook/config.jsandfacebook/index.js. It also removes theprofilesattribute fromorganization-enrichment-attributes.js.
🤖 Generated by Copilot at 5c5ca57
Why
How
🤖 Generated by Copilot at 5c5ca57
&--facebookand&--facebook:hoverclasses tobuttons.scssfor styling the Facebook button (link)config.jsandindex.jsfiles tofrontend/src/integrations/facebookfolder, exporting an object with the image and hideAsIntegration properties for the Facebook integration (link, link)IntegrationsConfigclass inintegrations-config.js, which provides the available integrations and their properties (link, link)username-handlesprop to theapp-platformcomponent for the GitHub, LinkedIn, Twitter, and Crunchbase identities inorganization-identities.vue, passing the organization's handles as arrays, to show the usernames on the platform button tooltips (link, link, link, link)app-platformcomponent for the Facebook identity inorganization-identities.vue, passing the organization's Facebook handle as an array, the tooltip label, the href, and the as-link props, to display the Facebook button with the profile link and username tooltip (link)props.organization.facebookcondition to theshowIdentitiescomputed property inorganization-identities.vue, to show the identities section if the organization has a Facebook identity (link)else ifbranch to thegetIdentityLinkmethod inorganization-identities.vue, to return the URL for the Facebook platform with the handle or the custom URL if available (link)aelement that displays the Facebook identity inorganization-view-aside.vue, with the same structure and style as the other platform links, and thehrefattribute with the Facebook profile URL (link)props.organization.facebookcondition to theshowIdentitiescomputed property inorganization-view-aside.vue, to show the identities section if the organization has a Facebook identity (link)&& !props.organization.facebook?.urlcondition to theshowIdentitiesWarningcomputed property inorganization-view-aside.vue, to hide the warning message about the missing identities if the organization has a custom Facebook URL (link)else ifbranch to thegetIdentityLinkmethod inorganization-view-aside.vue, to return the URL for the Facebook platform with the handle or the custom URL if available (link)Profilescolumn and theprofilesattribute from the organization components, as they are redundant with the platform buttons (link, link, link, link, link)Profilescolumn from theorganization-list-table.vuecomponent, which displayed the profiles of the organizations in a table (link)AppTagscomponent from theorganization-list-table.vuecomponent, which was used to display the profiles as tags (link)divelement that displayed the profiles attribute as tags in theorganization-enriched.vuecomponent, which showed the enriched data of the organization in the aside section (link)AppTagscomponent from theorganization-enriched.vuecomponent, which was used to display the profiles as tags (link)profilesattribute from theorganization-enrichment-attributes.jsfile, which defined the attributes for the organization enrichment (link)Checklist ✅
Feature,Improvement, orBug.