Skip to content

Trim activity display in slack automation #888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gaspergrom merged 4 commits into from
May 22, 2023
Merged

Trim activity display in slack automation #888

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bca407d
Trim activity display
gaspergrom May 22, 2023
9546e76
Fix lint and formatting
gaspergrom May 22, 2023
3da8eb1
Merge branch 'main' into improvement/automation-activity-trim
gaspergrom May 22, 2023
253f7ac
Fix formatting
gaspergrom May 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion backend/src/serverless/microservices/nodejs/automation/workers/slack/newActivityBlocks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,13 @@ const replaceHeadline = (text) => {
return text
}

const truncateText = (text: string, characters: number = 60): string => {
if (text.length > characters) {
return `${text.substring(0, characters)}...`
}
return text
}

export const newActivityBlocks = (activity) => {
const display = htmlToMrkdwn(replaceHeadline(`${activity.display.default}`))
const reach = activity.member.reach?.[activity.platform] || activity.member.reach?.total
Expand Down Expand Up @@ -76,7 +83,9 @@ export const newActivityBlocks = (activity) => {
type: 'section',
text: {
type: 'mrkdwn',
text: `*<${API_CONFIG.frontendUrl}/members/${activity.member.id}|${activity.member.displayName}>* \n *${display.text}*`,
text: `*<${API_CONFIG.frontendUrl}/members/${activity.member.id}|${
activity.member.displayName
}>* \n *${truncateText(display.text)}*`,
},
...(activity.url
? {
Expand Down
2 changes: 1 addition & 1 deletion backend/src/services/premium/enrichment/organizationEnrichmentService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ export default class OrganizationEnrichmentService extends LoggingBase {
) {
acc[platform] = {
handle,
[platform === PlatformType.TWITTER? "site": "url"]: social,
[platform === PlatformType.TWITTER ? 'site' : 'url']: social,
}
}
return acc
Expand Down