Boolean base filter#897
Merged
joanagmaia merged 2 commits intofeature/filtersfrom May 24, 2023
Merged
Conversation
joanagmaia
approved these changes
May 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed ✍️
What
🤖 Generated by Copilot at bf1e4d3
Implemented and modified various filter components and configurations to enable boolean filtering of members and fix bugs in date and enrichment filters. Added new partial components and props to support the boolean filter feature and improve the user interface. Changed the filter logic and label rendering for the
enrichedMember,joinedDate, andlastActivityDatefilters.
🤖 Generated by Copilot at bf1e4d3
Why
How
🤖 Generated by Copilot at bf1e4d3
enrichedMemberfilter would not work as expected for members who have never been enriched or have been enriched more than once, by using a different logic for filtering and rendering the filter value (link, link)joinedDateandlastActivityDatefilters, which would cause incorrect rendering and filtering of members by their date properties, by using theFilterConfigType.DATEinstead of theFilterConfigType.BOOLEAN(link, link)FilterItem.vuecomponent to pass an additional prop calledconfigto the dynamic component that renders the filter value, which allows the filter components to access the filter configuration object (link)configprop and use it to access the label and other options for the filter (link, link, link, link, link, link)SelectFilter.vuecomponent (link)apiFilterRendererByTypefrom./frontend/src/modules/member/config/filters/enrichedMember/config.ts, which improves the code readability and avoids unnecessary dependencies (link)Checklist ✅
Feature,Improvement, orBug.