Skip to content

Select filter options#900

Merged
gaspergrom merged 3 commits intofeature/filtersfrom
feature/select-filter
May 25, 2023
Merged

Select filter options#900
gaspergrom merged 3 commits intofeature/filtersfrom
feature/select-filter

Conversation

@gaspergrom
Copy link
Copy Markdown
Contributor

@gaspergrom gaspergrom commented May 25, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at 6258e18

This pull request adds a new SelectFilter component and enhances various member filters by importing type definitions and adding options parameters to the label renderers. This improves the type safety, the user interface, and the compatibility with the backend query logic of the filters. It also fixes some minor code style issues in the filter types.

🤖 Generated by Copilot at 6258e18

We're enhancing the filters for the members module
We're importing types and adding options to the label
We're heaving away on the SelectFilter component
We're making the chips show the values that we select

Why

How

🤖 Generated by Copilot at 6258e18

  • Add options parameter to itemLabelRenderer functions of various filters, and use it to display selected values or placeholders in filter chips (link, link, link, link, link, link, link, link, link, link, link, link, link)
  • Import relevant filter option types from filter config modules in filter config files (link, link, link, link, link, link, link, link, link, link, link, link)
  • Implement template for SelectFilter component, which renders a switch for include/exclude option and a list of grouped options (link, link)
  • Modify selectApiFilterRenderer function to use include option and overlap operator for backend compatibility (link)
  • Modify selectItemLabelRenderer function to use include option and display option label or placeholder (link)
  • Modify value prop type of FilterSelectOption component to accept boolean or string (link)
  • Add commas after type imports in filter components to follow code style (link, link, link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@gaspergrom gaspergrom added the Feature Created by Linear-GitHub Sync label May 25, 2023
@gaspergrom gaspergrom requested a review from joanagmaia May 25, 2023 09:10
@gaspergrom gaspergrom self-assigned this May 25, 2023
@gaspergrom gaspergrom merged commit a665aef into feature/filters May 25, 2023
@gaspergrom gaspergrom deleted the feature/select-filter branch May 25, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature Created by Linear-GitHub Sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants