Skip to content

Member enrichment upsert by existing platform instead of GitHub#906

Merged
epipav merged 1 commit intomainfrom
bugfix/member-enrichment-with-multiple-identities
May 29, 2023
Merged

Member enrichment upsert by existing platform instead of GitHub#906
epipav merged 1 commit intomainfrom
bugfix/member-enrichment-with-multiple-identities

Conversation

@epipav
Copy link
Copy Markdown
Collaborator

@epipav epipav commented May 26, 2023

  • Enrichment service was trying to upsert the member with GitHub platform always - This was causing a problem when the member was enriched by e-mail and didn't have any GitHub identities before. We were trying to upsert the member using the GitHub platform, and memberExists function was failing to return the existing member.
    Now we try to upsert the existing member with the first identity of the member instead of GitHub.

Changes proposed ✍️

What

🤖 Generated by Copilot at cfd812e

Improved the member service to handle different platforms and avoid errors. Refactored the memberService.upsert method and added a check for response.profile in memberEnrichmentService.ts.

🤖 Generated by Copilot at cfd812e

We are the members of the service
We rise from different platforms
We don't need no profile data
We upsert with our usernames

Why

How

🤖 Generated by Copilot at cfd812e

  • Enable upserting members from different platforms (link)
  • Fix possible error when accessing profile data (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@epipav epipav self-assigned this May 26, 2023
@epipav epipav added the Bug Created by Linear-GitHub Sync label May 26, 2023
@epipav epipav marked this pull request as ready for review May 26, 2023 12:17
@epipav epipav changed the title Enrichment member upserting by existing platform instead of GitHub Member enrichment upsert by existing platform instead of GitHub May 26, 2023
@epipav epipav requested review from joanreyero and sausage-todd May 26, 2023 12:18
@epipav epipav merged commit 74703a2 into main May 29, 2023
@epipav epipav deleted the bugfix/member-enrichment-with-multiple-identities branch May 29, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Created by Linear-GitHub Sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants