Number base filter#909
Merged
gaspergrom merged 4 commits intofeature/filtersfrom May 30, 2023
Merged
Conversation
joanagmaia
reviewed
May 29, 2023
joanagmaia
approved these changes
May 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed ✍️
What
🤖 Generated by Copilot at 9432069
This pull request adds the number filter component and improves the filter UI for the frontend. It defines the
NumberFilterConfigandFilterOperatortypes and thenumber.constantsmodule to store the filter operators and values. It updates theFilter,FilterDropdown,FilterInlineSelect, andFilterInputcomponents to use the new popover, tooltip, and error features. It modifies thenumber.filter.renderer,number.label.renderer, andnumber.parserfunctions to handle different filter operators and values. It adds theAppFormErrorscomponent and thedropdown.scssstyle rule to display the validation errors and the active state of the filter items.
🤖 Generated by Copilot at 9432069
Why
How
🤖 Generated by Copilot at 9432069
AppFormErrorsto display validation errors for form inputs (link)AppFormItemcomponent to passerrorIconanderrorClassprops toAppFormErrorsand add them to its own props (link, link)el-dropdowncomponent with theel-popovercomponent for the filter dropdown menu and add awidth, apopper-class, and areferenceslot to it (link)subLabelprop to the filter options and theFilterInlineSelectcomponent to display additional information about the filter operators (link, link, link)CUSTOM ATTRIBUTESsection to the filter dropdown menu to show the custom filters separately from the default ones (link)openref to theFilterDropdowncomponent to track the visibility of the popover and set it to false when an option is selected (link, link)el-dropdowncomponent with theel-tooltipcomponent for the filter operator switch and add a tooltip effect that shows the alternative operator (link)CrFilterInlineSelect,CrFilterInput,AppFormItem, andAppFormErrorscomponents and theminValue,numeric, andrequiredvalidators (link, link, link)numberApiFilterRenderer,numberItemLabelRenderer, andnumberQueryUrlParserfunctions to handle different filter operators and values using theFilterNumberOperatorenum and thenumberFilterOperatorsarray (link, link, link, link, link, link)FilterOperatorthat defines theFilterOperatorinterface for the filter operator objects (link)cr-filter-itemcomponent (link)filter-inputclass tofilter-input-fieldand modify its style rules (link, link, link)flex-wrapclass to theFilterInlineSelectcomponent to allow the prefix and the selected option to wrap to a new line (link)Checklist ✅
Feature,Improvement, orBug.