Multiselect base filter#922
Merged
gaspergrom merged 5 commits intofeature/filtersfrom Jun 1, 2023
Merged
Conversation
joanagmaia
approved these changes
May 31, 2023
Contributor
joanagmaia
left a comment
There was a problem hiding this comment.
Just missing the Lint fix, failing on the pipeline
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed ✍️
What
🤖 Generated by Copilot at 4dda61f
This pull request adds support for multiselect async filters in the frontend. It introduces new components, types, and functions to handle the rendering, fetching, and querying of these filters. It also enhances the existing multiselect filters by adding a dynamic switch between checkbox and tag subcomponents based on the number of options. Additionally, it fixes some minor issues in the formatting, styling, and null checking of the filters component. The files affected are mainly in the
frontend/src/shared/modules/filtersfolder and thefrontend/src/modules/activity/config/filters/member/config.tsfile.
🤖 Generated by Copilot at 4dda61f
Why
How
🤖 Generated by Copilot at 4dda61f
tooltip.scssfile and add thedata-tooltipattribute to enable the tooltip style for the filter item labels (link, link)dataparameter and thev-model:datadirective to theFilterItem.vuecomponent to enable two-way binding and passing data to the label renderer (link, link, link)FilterItem.vuecomponent for code formatting (link)Checklist ✅
Feature,Improvement, orBug.