Skip to content

Multiselect base filter#922

Merged
gaspergrom merged 5 commits intofeature/filtersfrom
feature/multiselect-filter
Jun 1, 2023
Merged

Multiselect base filter#922
gaspergrom merged 5 commits intofeature/filtersfrom
feature/multiselect-filter

Conversation

@gaspergrom
Copy link
Copy Markdown
Contributor

@gaspergrom gaspergrom commented May 31, 2023

Changes proposed ✍️

image image

What

🤖 Generated by Copilot at 4dda61f

This pull request adds support for multiselect async filters in the frontend. It introduces new components, types, and functions to handle the rendering, fetching, and querying of these filters. It also enhances the existing multiselect filters by adding a dynamic switch between checkbox and tag subcomponents based on the number of options. Additionally, it fixes some minor issues in the formatting, styling, and null checking of the filters component. The files affected are mainly in the frontend/src/shared/modules/filters folder and the frontend/src/modules/activity/config/filters/member/config.ts file.

🤖 Generated by Copilot at 4dda61f

Filters component
Enhanced with multiselect
Autumn leaves falling

Why

How

🤖 Generated by Copilot at 4dda61f

  • Add and modify components, config files, and functions to enable multiselect async filter type and improve multiselect filter type (link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link)
  • Import the tooltip.scss file and add the data-tooltip attribute to enable the tooltip style for the filter item labels (link, link)
  • Add the data parameter and the v-model:data directive to the FilterItem.vue component to enable two-way binding and passing data to the label renderer (link, link, link)
  • Remove an extra line break in the FilterItem.vue component for code formatting (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@gaspergrom gaspergrom added the Feature Created by Linear-GitHub Sync label May 31, 2023
@gaspergrom gaspergrom requested a review from joanagmaia May 31, 2023 06:42
@gaspergrom gaspergrom self-assigned this May 31, 2023
Copy link
Copy Markdown
Contributor

@joanagmaia joanagmaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just missing the Lint fix, failing on the pipeline

@gaspergrom gaspergrom changed the title Feature/multiselect filter Multiselect base filter Jun 1, 2023
@gaspergrom gaspergrom merged commit a23e2ee into feature/filters Jun 1, 2023
@gaspergrom gaspergrom deleted the feature/multiselect-filter branch June 1, 2023 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature Created by Linear-GitHub Sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants