Activity & Conversation new filters#955
Merged
gaspergrom merged 7 commits intofeature/filtersfrom Jun 8, 2023
Merged
Conversation
joanagmaia
reviewed
Jun 7, 2023
Contributor
joanagmaia
left a comment
There was a problem hiding this comment.
Looks great!
One thing I noticed while testing was that conversation query endpoint is returning 500. Looked at the logs and it seems that is because of the orderBy value being passed:
column conversation.timestamp does not exist
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed ✍️
What
🤖 Generated by Copilot at 3f1ad74
This pull request refactors the activity and conversation modules to use the pinia store and the CrFilter component for data and filter management, and to improve the UI and functionality of the filter components. It also fixes a typo in the auth layout and adds a search filter for the activity list. The changes affect the following files:
activity-list.vue,ActivityTypeFilter.vue,config.tsfor various filters,activity-list-page.vue,conversation-list.vue,activity-service.js,actions.ts,getters.ts,index.ts,state.ts,auth-layout-side.vue,ChannelFilter.vue, andconfig.tsfor the channel filter.
🤖 Generated by Copilot at 3f1ad74
Why
How
🤖 Generated by Copilot at 3f1ad74
Checklist ✅
Feature,Improvement, orBug.