Skip to content

Organization filters connect#960

Merged
gaspergrom merged 2 commits intofeature/filtersfrom
improvement/organization-new-filters
Jun 7, 2023
Merged

Organization filters connect#960
gaspergrom merged 2 commits intofeature/filtersfrom
improvement/organization-new-filters

Conversation

@gaspergrom
Copy link
Copy Markdown
Contributor

@gaspergrom gaspergrom commented Jun 7, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at d11e8e0

Refactored the organization module to use pinia for state management, added new filters and a search filter for the organization list, and implemented saved views with hardcoded views and a team organization setting.

🤖 Generated by Copilot at d11e8e0

Sing, O Muse, of the mighty pull request
That added many filters to the organization module
And refactored the code with pinia and OrganizationService
To improve the performance and the state of the data.

Why

How

🤖 Generated by Copilot at d11e8e0

  • Refactor organization list table component to use pinia store instead of vuex store (link, link, link, link, link, link, link, link, link, link, link, link)
  • Move organization list toolbar component to organization-list-table.vue and update bulk actions logic to use pinia store and OrganizationService (link, link, link, link, link, link, link)
  • Refactor organization dropdown component to use pinia store and OrganizationService (link, link, link, link)
  • Change organization name component to show name as fallback for display name (link, link)
  • Change itemLabelRenderer and apiFilterRenderer functions for active on, joined date, last activity date, number of activities, and number of members filters to use generic functions for different filter types (link, link, link, link, link, link, link, link, link, link)
  • Add enriched organization, founded, headcount, headline, industry, location, and type filters to organization filters config and options (link, link, link, link, link, link, link, link, link)
  • Add organization saved views main file with saved views config and hardcoded views (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@gaspergrom gaspergrom added the Improvement Created by Linear-GitHub Sync label Jun 7, 2023
@gaspergrom gaspergrom requested a review from joanagmaia June 7, 2023 14:44
@gaspergrom gaspergrom self-assigned this Jun 7, 2023
Comment thread frontend/src/modules/report/pages/templates/report-template-page.vue Outdated
@gaspergrom gaspergrom merged commit a111ebb into feature/filters Jun 7, 2023
@gaspergrom gaspergrom deleted the improvement/organization-new-filters branch June 7, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Improvement Created by Linear-GitHub Sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants