Skip to content

Fix analytics env setting#998

Merged
gaspergrom merged 1 commit intomainfrom
bugfix/analytics-fix
Jun 19, 2023
Merged

Fix analytics env setting#998
gaspergrom merged 1 commit intomainfrom
bugfix/analytics-fix

Conversation

@gaspergrom
Copy link
Copy Markdown
Contributor

@gaspergrom gaspergrom commented Jun 19, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at 18b6612

Improve analytics and feedback integration in frontend/index.html by fixing the variable assignment logic.

🤖 Generated by Copilot at 18b6612

No more undefined or placeholders
We need the keys to unlock our powers
segmentKey and pendoKey are the tools
To track and improve our feedback rules

Why

How

🤖 Generated by Copilot at 18b6612

  • Simplify and standardize the logic for setting segmentKey and pendoKey variables for analytics and feedback (link, link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@gaspergrom gaspergrom added the Bug Created by Linear-GitHub Sync label Jun 19, 2023
@gaspergrom gaspergrom requested a review from joanagmaia June 19, 2023 14:13
@gaspergrom gaspergrom self-assigned this Jun 19, 2023
@gaspergrom gaspergrom merged commit 6fc8f51 into main Jun 19, 2023
@gaspergrom gaspergrom deleted the bugfix/analytics-fix branch June 19, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Created by Linear-GitHub Sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants