Missing ID on Commit: Newly created PR for missing ID contains a foreign commit

[thakurveerendras]

Summary

Newly created PR for missing ID contains a foreign commit

Setup

Add a not-exit email address on .gitconfig file

Background

1. Clone cla enabled repo
2. Create new branch
3. Make some changes or add the new file
4. Add new PR

• git Add .
• git commit -m "test"
• git push origin

Expected behavior

PR: CLATestOrg/VulDetect1#78

Results obtains

PR: CLATestOrg/VulDetect1#98

[lukaszgryglicki]

So what I did was:

• I've created a new git branch via: git checkout -b unicron-test-missing-id.
• Then I've run git config --local include.path ../.gitconfig so it will read local config from .gitconfig.
• Then I've gitignored this file by adding .gitconfig in .gitignore file.

• Then I added this file for committing: git add ..
• Then I've committed: git commit -m "test missing id".
• Now git log looks like this (note my commit 594b2ae66cc14226cb78f2149ecafb77c9f2aaf3 is with non-existing email):

git log
commit 594b2ae66cc14226cb78f2149ecafb77c9f2aaf3 (HEAD -> unicron-test-missing-id, origin/unicron-test-missing-id)
Author: Łukasz Gryglicki <not-existing@o2.pl>
Date:   Thu Jan 16 08:32:42 2025 +0000

    test missing id

commit ba114365ac8eefa4cf69b56ca001ad6617d1b9bc (origin/master, origin/HEAD, master)

• Next I've pushed branch: git push --set-upstream origin unicron-test-missing-id.
• Then I've created a PR (#102) from that branch https://github.com/CLATestOrg/VulDetect1/compare/unicron-test-missing-id?expand=1.
• EasyCLA correctly detects missing ID, message is:

❌ The email address for the commit (https://github.com/CLATestOrg/VulDetect1/commit/594b2ae66cc14226cb78f2149ecafb77c9f2aaf3) is not linked to the GitHub account, preventing the EasyCLA check. Consult [this Help Article](https://linuxfoundation.atlassian.net/wiki/spaces/LP/pages/160923756/Missing+ID+on+Commit+but+I+have+an+agreement+on+file) and [GitHub Help](https://help.github.com/en/github/committing-changes-to-your-project/why-are-my-commits-linked-to-the-wrong-user) to resolve. (To view the commit's email address, add .patch at the end of this PR page's URL.) For further assistance with EasyCLA, [please submit a support request ticket](https://jira.linuxfoundation.org/servicedesk/customer/portal/4).

It refers to 594b2ae commit which is exactly my commit:

git log 594b2ae
commit 594b2ae66cc14226cb78f2149ecafb77c9f2aaf3 (HEAD -> unicron-test-missing-id, origin/unicron-test-missing-id)
Author: Łukasz Gryglicki <not-existing@o2.pl>
Date:   Thu Jan 16 08:32:42 2025 +0000

    test missing id

with missing ID - I don't see anything wrong with this - I don't see any other commis referred.

I case of your PR reported: CLATestOrg/VulDetect1#98 - I see EasyCLA listed two commits: 1e0fd7d and 655410a but when I check this PR by adding .patch at the end: https://patch-diff.githubusercontent.com/raw/CLATestOrg/VulDetect1/pull/98.patch I can see that this PR is indeed made of those two commits mentioned by EasyCLA:

From 1e0fd7deb61ffcf1b2ab60d67e5bcfe045982d55 Mon Sep 17 00:00:00 2001
From: veerendra thakur <veerendrat+3457@proximabiz.com>
Date: Fri, 14 Jun 2024 17:34:01 +0530
Subject: [PATCH 1/2] test missig id

---
 README.md | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/README.md b/README.md
index 58e30e6..4f09351 100644
--- a/README.md
+++ b/README.md
@@ -1 +1,2 @@
-# VulDetect1
\ No newline at end of file
+# VulDetect1
+test
\ No newline at end of file

From 655410ab94c295394367c8a15ca1d50538ff2aa4 Mon Sep 17 00:00:00 2001
From: veerendra thakur <veerendrat+23757615371357615376153@proximabiz.com>
Date: Wed, 15 Jan 2025 13:43:25 +0530
Subject: [PATCH 2/2] test missing id case on prod

---
 README.md | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/README.md b/README.md
index 4f09351..8c6f57c 100644
--- a/README.md
+++ b/README.md
@@ -1,2 +1,3 @@
-# VulDetect1
-test
\ No newline at end of file
+# VulDetect1
+test
+test2
\ No newline at end of file

When I check the branch from which this commit is made it is also showing "2 commits ahead": https://github.com/CLATestOrg/VulDetect1/tree/prodjan25, here you can see those exact commits listed by EasyCLA: CLATestOrg/VulDetect1@master...prodjan25

I really see no bug here - EasyCLA message is in perfect sync with what GitHub UI shows.

No idea what needs to be done here - nothing IMHO. cc @mlehotskylf @thakurveerendras

[thakurveerendras]

Thanks @lukaszgryglicki
Requesting you to add one more PR (on the new branch) & let me know if not replicated. I will try to find out the steps

[lukaszgryglicki]

That was on the new branch, I've listed everything step by step.
You can use GitHub UI to see which commits are "included" in a PR - easyCLA listed the same as GitHub so I guess both are OK.

[lukaszgryglicki]

One more PR as requested: CLATestOrg/VulDetect1#103, https://patch-diff.githubusercontent.com/raw/CLATestOrg/VulDetect1/pull/103.patch

commands:

root@darkstar:~/go/src/github.com/CLATestOrg/VulDetect1# git branch
* master
  unicron-test-missing-id
root@darkstar:~/go/src/github.com/CLATestOrg/VulDetect1# git status
On branch master
Your branch is up to date with 'origin/master'.

Untracked files:
  (use "git add <file>..." to include in what will be committed)
	.gitignore

nothing added to commit but untracked files present (use "git add" to track)
root@darkstar:~/go/src/github.com/CLATestOrg/VulDetect1# git checkout -b unicron-another-pr
Switched to a new branch 'unicron-another-pr'
root@darkstar:~/go/src/github.com/CLATestOrg/VulDetect1# vim .git
.git/       .gitconfig  .gitignore  
root@darkstar:~/go/src/github.com/CLATestOrg/VulDetect1# vim .git/
COMMIT_EDITMSG  FETCH_HEAD      HEAD            ORIG_HEAD       branches/       config          description     hooks/          index           info/           logs/           objects/        packed-refs     refs/           
root@darkstar:~/go/src/github.com/CLATestOrg/VulDetect1# vim .git/config 
root@darkstar:~/go/src/github.com/CLATestOrg/VulDetect1# vim .gitconfig 
root@darkstar:~/go/src/github.com/CLATestOrg/VulDetect1# git status
On branch unicron-another-pr
Untracked files:
  (use "git add <file>..." to include in what will be committed)
	.gitignore

nothing added to commit but untracked files present (use "git add" to track)
root@darkstar:~/go/src/github.com/CLATestOrg/VulDetect1# vim .gitignore 
root@darkstar:~/go/src/github.com/CLATestOrg/VulDetect1# git add .
root@darkstar:~/go/src/github.com/CLATestOrg/VulDetect1# git commit -asm "One more"
[unicron-another-pr 7188013] One more
 1 file changed, 1 insertion(+)
 create mode 100644 .gitignore
root@darkstar:~/go/src/github.com/CLATestOrg/VulDetect1# git push
fatal: The current branch unicron-another-pr has no upstream branch.
To push the current branch and set the remote as upstream, use

    git push --set-upstream origin unicron-another-pr

root@darkstar:~/go/src/github.com/CLATestOrg/VulDetect1# git push --set-upstream origin unicron-another-pr
Enumerating objects: 4, done.
Counting objects: 100% (4/4), done.
Delta compression using up to 64 threads
Compressing objects: 100% (2/2), done.
Writing objects: 100% (3/3), 316 bytes | 316.00 KiB/s, done.
Total 3 (delta 0), reused 0 (delta 0)
remote: 
remote: Create a pull request for 'unicron-another-pr' on GitHub by visiting:
remote:      https://github.com/CLATestOrg/VulDetect1/pull/new/unicron-another-pr
remote: 
To https://github.com/CLATestOrg/VulDetect1.git
 * [new branch]      unicron-another-pr -> unicron-another-pr
Branch 'unicron-another-pr' set up to track remote branch 'unicron-another-pr' from 'origin'.
root@darkstar:~/go/src/github.com/CLATestOrg/VulDetect1# git log | head
commit 7188013059ff873d82bd028f5c6eb63aa2034435
Author: Łukasz Gryglicki <not-existing@o2.pl>
Date:   Thu Jan 16 11:15:56 2025 +0000

    One more
    
    Signed-off-by: Łukasz Gryglicki <not-existing@o2.pl>

commit ba114365ac8eefa4cf69b56ca001ad6617d1b9bc
Merge: f3dff37 10c9629

The same - single commit and "missing ID" which is correct because I've put unknown email ID in my .gitconfig.

[lukaszgryglicki]

This should be closed IMHO.

[lukaszgryglicki]

Moving this to blocked, but this should be closed IMHO - all is correct.

[thakurveerendras]

@lukaszgryglicki , It is reproducible with only one user & I am trying to replicate this issue on another user.
Closing this issue as it is limited to one user. will reopened if I able to replicate it on another user.