Skip to content

Allow GitLab EasyCLA status comment on MRs from forked repos#5053

Merged
lukaszgryglicki merged 1 commit into
mainfrom
unicron-allow-gitlab-easycla-comment-status-from-forked-repo-merge-request
May 14, 2026
Merged

Allow GitLab EasyCLA status comment on MRs from forked repos#5053
lukaszgryglicki merged 1 commit into
mainfrom
unicron-allow-gitlab-easycla-comment-status-from-forked-repo-merge-request

Conversation

@lukaszgryglicki
Copy link
Copy Markdown
Member

Signed-off-by: Lukasz Gryglicki lgryglicki@cncf.io

Assisted by OpenAI

Assisted by GitHub Copilot

Assisted by Claude

Signed-off-by: Lukasz Gryglicki <lgryglicki@cncf.io>

Assisted by [OpenAI](https://platform.openai.com/)

Assisted by [GitHub Copilot](https://github.com/features/copilot)

Assisted by [Claude](https://claude.ai)
Copilot AI review requested due to automatic review settings May 14, 2026 06:15
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 14, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: acd9ef93-ea7c-4f92-9dae-60627e7678d7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch unicron-allow-gitlab-easycla-comment-status-from-forked-repo-merge-request

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR makes the GitLab EasyCLA flow resilient to fork-based merge requests. Previously, when a webhook fired for an MR opened from a fork, SetCommitStatus could return a 404 because the commit SHA only exists in the fork's refs (not the upstream project the webhook targets), and the early return prevented the MR comment (containing the sign URL) from ever being posted. Now status failures are logged as warnings and the flow continues so the contributor still gets the comment with the sign URL.

Changes:

  • Stop returning early when SetCommitStatus fails in both the missing-users and signed paths.
  • Refactor the success path to use an if-with-init style consistent with the failure path.
  • Add an explanatory comment about the fork/404 scenario.

@lukaszgryglicki lukaszgryglicki merged commit b5f586f into main May 14, 2026
11 checks passed
@lukaszgryglicki lukaszgryglicki deleted the unicron-allow-gitlab-easycla-comment-status-from-forked-repo-merge-request branch May 14, 2026 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants